Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http auth to client #6

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Added http auth to client #6

merged 1 commit into from
Jul 26, 2020

Conversation

minsis
Copy link

@minsis minsis commented Feb 27, 2020

I just used the same unittest only with username/password added in. I'm sure there's probably a better way of testing it, but it still passes without any exceptions from requests.

Copy link
Owner

@wbrefvem wbrefvem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def test_unresolvable_agent(self):

self.jc = JolokiaClient('http://trythelandcrab.com', 'myuser', 'mypasswd')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@wbrefvem wbrefvem merged commit efa6a3a into wbrefvem:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants