Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "File Icons Extended" to "zz File Icons" #5852

Merged
merged 1 commit into from Oct 28, 2016
Merged

Rename "File Icons Extended" to "zz File Icons" #5852

merged 1 commit into from Oct 28, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2016

No description provided.

@wbond
Copy link
Owner

wbond commented Oct 3, 2016

Why? Having a package start with zz sound suspiciously like some sort of hacky solution.

@ghost
Copy link
Author

ghost commented Oct 3, 2016

@wbond Yes, that's hacky solution 😉 I need this to add icons if they aren't provided by the theme.

If the theme has support of this package (it should have icons with the same names as in this package) it does nothing, however you can force override icons. See package settings.

P.S. Working on file-icons package which adds functionality like atom's file icons.

@ghost ghost changed the title Rename "File Icons Extended" to "zz File Icons" Rename "File Icons Extended" to "zzFileIcons" Oct 4, 2016
@ghost ghost changed the title Rename "File Icons Extended" to "zzFileIcons" Rename "File Icons Extended" to "zz File Icons" Oct 11, 2016
@ghost
Copy link
Author

ghost commented Oct 11, 2016

@wbond I've updated the readme and added explanation section to describe how it works. It's ready to rename. I'll publish 2.0.0 right after renaming.

ghost referenced this pull request in material-theme/vsc-material-theme Oct 13, 2016
BREAKING CHANGE:

From this release Material Theme use the `zz-file-icons` package to
display file type icons. Please install it and restart Sublime Text.
@equinusocio
Copy link
Contributor

Any update? we all need this package :)

@equinusocio
Copy link
Contributor

Ping @wbond @FichteFoll :)

@equinusocio
Copy link
Contributor

equinusocio commented Oct 25, 2016

1 month for a PR.. PC needs a better review system :(

@equinusocio
Copy link
Contributor

@oivva I think i will restore old icons support, and i will release material theme 4 until this PR is merged.

@ghost
Copy link
Author

ghost commented Oct 28, 2016

@equinusocio OK, I'll message you when it will be released 😉

@FichteFoll
Copy link
Collaborator

PC needs a better review system :(

I agree, but it's still some time off until that will happen.

I'll see if I can get the easier to review PRs done this weekend (namely package renames and ownership changes), so that the technically already reviewd packages will get the changes applied sooner rather than later.
Package additions will most likely have to wait for a little while longer.

Since this is only a rename, I'll go ahead an merge it right now (even though you mentioned me).

@FichteFoll FichteFoll merged commit bb35d24 into wbond:master Oct 28, 2016
@equinusocio
Copy link
Contributor

Thanks!!

@gnowland
Copy link

Hooray! 🙌
On Fri, Oct 28, 2016 at 2:09 PM Mattia Astorino notifications@github.com
wrote:

Thanks!!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5852 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEOZJ2stjRiTW0a9nKOAJPOT57_NnQ1wks5q4kebgaJpZM4KMlLo
.

Gifford Nowland
(302) 898-4597 | gnowland@gmail.com
http://www.giffordnowland.com

taylorzane pushed a commit to adelyte/package_control_channel that referenced this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants