-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "File Icons Extended" to "zz File Icons" #5852
Conversation
Why? Having a package start with |
@wbond Yes, that's hacky solution 😉 I need this to add icons if they aren't provided by the theme. If the theme has support of this package (it should have icons with the same names as in this package) it does nothing, however you can force override icons. See package settings. P.S. Working on |
@wbond I've updated the readme and added explanation section to describe how it works. It's ready to rename. I'll publish 2.0.0 right after renaming. |
BREAKING CHANGE: From this release Material Theme use the `zz-file-icons` package to display file type icons. Please install it and restart Sublime Text.
Any update? we all need this package :) |
Ping @wbond @FichteFoll :) |
1 month for a PR.. PC needs a better review system :( |
@oivva I think i will restore old icons support, and i will release material theme 4 until this PR is merged. |
@equinusocio OK, I'll message you when it will be released 😉 |
I agree, but it's still some time off until that will happen. I'll see if I can get the easier to review PRs done this weekend (namely package renames and ownership changes), so that the technically already reviewd packages will get the changes applied sooner rather than later. Since this is only a rename, I'll go ahead an merge it right now (even though you mentioned me). |
Thanks!! |
Hooray! 🙌
|
No description provided.