Fix configure failures with Xcode12 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes are needed becuase Xcode12 includes a default of -Werror,-Wimplicit-function-declaration which means that even something like calling "exit(0);" is a compile failure if you haven't done a "#include <stdlib.h>" first (as C99 requires, but most other compilers will just warn about) I don't know if the "long long reliability test 2" test which tries to provoke a crash on a particular gcc 3.3 build still does what it was originally intended to do with my change. Of course, I doubt anyone has tried to use that compiler in years. Fixes wbhart#290
mitchblank
added a commit
to mitchblank/homebrew-core
that referenced
this pull request
Dec 21, 2020
I opened a PR on upstream package wbhart/mpir#292 which I am importing here. Does require regenerating ./configure script, of course.
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 24, 2020
* mpir: fix build on Xcode 12 I opened a PR on upstream package wbhart/mpir#292 which I am importing here. Does require regenerating ./configure script, of course. * switch these to https to make CI happy Closes #67369. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are needed because Xcode12 includes a default of
-Werror,-Wimplicit-function-declarationwhich means thateven something like calling
exit(0);is a compile failure if you haven't done a#include <stdlib.h>first (as C99 requires, but most other compilers will just warn about)I don't know if the "long long reliability test 2" test which tries to provoke a crash on a particular gcc 3.3 build still
does what it was originally intended to do with my change. Of course, I doubt anyone has tried to use that compiler in years.
Fixes #290