Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gitpython from 3.1.18 to 3.1.29 #272

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2022

Additional Changes Included

In addition to the proposed dependency upgrade, I modified our code to be type compatible with the return value of git.Repo.working_dir, which is Optional (Couldn't determine exactly when this changed, but suspect it was between gitpython versions 3.1.18 and 3.1.29

Basically, all code accessing git.Repo.working_dir and then providing the value to a pathlib or os operation should use the new pygitops._util.repo_working_dir function that will raise an error when the working dir is None


Bumps gitpython from 3.1.18 to 3.1.29.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.18 to 3.1.29.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.18...3.1.29)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #272 (4de2427) into main (d45e98f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          165       173    +8     
  Branches        19        20    +1     
=========================================
+ Hits           165       173    +8     
Impacted Files Coverage Δ
pygitops/_util.py 100.00% <100.00%> (ø)
pygitops/exceptions.py 100.00% <100.00%> (ø)
pygitops/operations.py 100.00% <100.00%> (ø)

@dependabot dependabot bot force-pushed the dependabot/pip/gitpython-3.1.29 branch 3 times, most recently from 511bb47 to a2b4f22 Compare October 17, 2022 12:43
@jdw6359 jdw6359 force-pushed the dependabot/pip/gitpython-3.1.29 branch from 779c3f3 to d08667a Compare October 17, 2022 14:23
Copy link
Contributor

@stephanlensky stephanlensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jdw6359 jdw6359 merged commit 834b476 into main Oct 17, 2022
@jdw6359 jdw6359 deleted the dependabot/pip/gitpython-3.1.29 branch October 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants