Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Release 5.3.0 #482

Merged
merged 26 commits into from
Sep 14, 2021
Merged

SDK Release 5.3.0 #482

merged 26 commits into from
Sep 14, 2021

Conversation

nan2iz
Copy link
Contributor

@nan2iz nan2iz commented Sep 9, 2021

Service Changes

Assistant V1

alt_text property added to Image response type


Assistant V2

session_start_time and state properties added to MessageContextGlobalSystem model
alt_text property added to Image response type
location property of RuntimeEntity model changed from required to optional


Discovery V2
Enum update for CreateProjectConstants

NLU
Fix for listClassificationsModels through return type change and removal of unnecessary model

STT
More languages supported for next generation models

TTS
New voice models added

CC, Disco V1, LT, NLC, PI, TA, VisRec V3 & V4
No changes

@nan2iz nan2iz requested a review from kevinkowa September 9, 2021 00:40
@@ -1825,7 +1828,7 @@ public DetailedResponse<AnalyzedDocument> AnalyzeDocument(string projectId, stri

if (file != null)
{
var fileContent = new StreamContent(file);
var fileContent = new ByteArrayContent(file.ToArray());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinkowa when we reviewed this one together. I remember that we ignored this change.
I was about to revert back to var fileContent = new StreamContent(file); but also found that every other places use ByteArrayContent. So I'm wondering if we should just add this change since I did not see any test failure on DiscoveryService. But, I also don't know if it need to be kept as SteamContent. Please let me know if we want to convert this part back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets discard this change. If this is no longer an issue we can check it out when we do a major release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good after this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! I updated the change. Thank you

@jeff-arn jeff-arn requested a review from mediumTaj September 9, 2021 14:49
@@ -1825,7 +1828,7 @@ public DetailedResponse<AnalyzedDocument> AnalyzeDocument(string projectId, stri

if (file != null)
{
var fileContent = new StreamContent(file);
var fileContent = new ByteArrayContent(file.ToArray());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets discard this change. If this is no longer an issue we can check it out when we do a major release

@nan2iz nan2iz changed the title SDK Release 5.2.1 SDK Release 5.3.0 Sep 9, 2021
@nan2iz nan2iz requested a review from kevinkowa September 13, 2021 16:13
@nan2iz
Copy link
Contributor Author

nan2iz commented Sep 14, 2021

@kevinkowa the PR is ready to be reviewed again. Thanks

Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after this change

/// Routing or other contextual information to be used by target service desk systems.
/// </summary>
[JsonProperty("transfer_info", NullValueHandling = NullValueHandling.Ignore)]
public DialogNodeOutputConnectToAgentTransferInfo TransferInfo { get; protected set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can discard this change, TransferInfo is not required here

Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nan2iz nan2iz merged commit b3ce587 into master Sep 14, 2021
@nan2iz nan2iz deleted the sdk-5.2.1 branch September 14, 2021 18:15
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants