-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Release 5.3.0 #482
SDK Release 5.3.0 #482
Conversation
…MessageContextGlobalSystem
…d removal of unnecessary model
… in TestListClassificationModel
@@ -1825,7 +1828,7 @@ public DetailedResponse<AnalyzedDocument> AnalyzeDocument(string projectId, stri | |||
|
|||
if (file != null) | |||
{ | |||
var fileContent = new StreamContent(file); | |||
var fileContent = new ByteArrayContent(file.ToArray()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinkowa when we reviewed this one together. I remember that we ignored this change.
I was about to revert back to var fileContent = new StreamContent(file);
but also found that every other places use ByteArrayContent
. So I'm wondering if we should just add this change since I did not see any test failure on DiscoveryService. But, I also don't know if it need to be kept as SteamContent
. Please let me know if we want to convert this part back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets discard this change. If this is no longer an issue we can check it out when we do a major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good after this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! I updated the change. Thank you
@@ -1825,7 +1828,7 @@ public DetailedResponse<AnalyzedDocument> AnalyzeDocument(string projectId, stri | |||
|
|||
if (file != null) | |||
{ | |||
var fileContent = new StreamContent(file); | |||
var fileContent = new ByteArrayContent(file.ToArray()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets discard this change. If this is no longer an issue we can check it out when we do a major release
…ment to the original code
…tion to authenticated
@kevinkowa the PR is ready to be reviewed again. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after this change
/// Routing or other contextual information to be used by target service desk systems. | ||
/// </summary> | ||
[JsonProperty("transfer_info", NullValueHandling = NullValueHandling.Ignore)] | ||
public DialogNodeOutputConnectToAgentTransferInfo TransferInfo { get; protected set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can discard this change, TransferInfo is not required here
…neric for assistant-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Service Changes
Assistant V1
alt_text
property added to Image response type
Assistant V2
session_start_time
andstate
properties added toMessageContextGlobalSystem
modelalt_text
property added to Image response typelocation property of RuntimeEntity model changed from required to optional
Discovery V2
Enum
update forCreateProjectConstants
NLU
Fix for
listClassificationsModels
through return type change and removal of unnecessary model
STT
More languages supported for next generation models
TTS
New voice models added
CC, Disco V1, LT, NLC, PI, TA, VisRec V3 & V4
No changes