url: restrict setting protocol to "file"

Since file URLs can not have `username/password/port`, the specification was updated to restrict setting protocol to "file". Refs: whatwg/url#269 Fixes: nodejs#11785
watilde · Mar 18, 2017 · 9d4d73f · 9d4d73f
1 parent 5bfd13b
commit 9d4d73f
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -133,6 +133,13 @@ function onParseProtocolComplete(flags, protocol, username, password,
   if ((s && !newIsSpecial) || (!s && newIsSpecial)) {
     return;
   }
+  if (protocol === 'file:' &&
+    (ctx.username || ctx.password || ctx.port !== undefined)) {
+    return;
+  }
+  if (ctx.scheme === 'file:' && !ctx.host) {
+    return;
+  }
   if (newIsSpecial) {
     ctx.flags |= binding.URL_FLAGS_SPECIAL;
   } else {