Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Simple ASM2d Packages #1531

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Delete Simple ASM2d Packages #1531

merged 2 commits into from
Dec 2, 2024

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

These were supposed to be deleted in #1506, but ironically I missed the property and reaction packages themselves

Summary/Motivation:

Follow-up to #1506

Changes proposed in this PR:

  • Delete simplified ASM2d packages

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added the Priority:Normal Normal Priority Issue or PR label Nov 22, 2024
@MarcusHolly MarcusHolly self-assigned this Nov 22, 2024
agarciadiego
agarciadiego approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-a-a adam-a-a enabled auto-merge (squash) December 2, 2024 20:24
@adam-a-a adam-a-a merged commit f31d9b4 into watertap-org:main Dec 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@agarciadiego agarciadiego agarciadiego approved these changes

@luohezhiming luohezhiming luohezhiming approved these changes

Assignees

@MarcusHolly MarcusHolly

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcusHolly @adam-a-a @agarciadiego @luohezhiming