Update Dye Desal Flowsheet Parameters #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-a-a
reviewed
Dec 5, 2024
Comment on lines
1599
to
1651
| # Dye removal | ||
| # dye_removed = value(m.fs.gac.gac_removed[0].flow_mass_phase_comp["Liq", "dye"]) | ||
| # dye_total = value( | ||
| # m.fs.gac.process_flow.properties_in[0].flow_mass_phase_comp["Liq", "dye"] | ||
| # ) | ||
| # removal_percentage = (dye_removed / dye_total) * 100 | ||
| # print(f"\nDye removal is {removal_percentage} %") | ||
|
|
||
| # Adsorption Capacity: q = (C_o - C_e)V/m | ||
| # inlet_dye = value( | ||
| # m.fs.gac.process_flow.properties_in[0].conc_mass_phase_comp["Liq", "dye"] | ||
| # ) | ||
| # print(f"GAC inlet dye concentration is {inlet_dye}") | ||
| # outlet_dye = value( | ||
| # m.fs.gac.process_flow.properties_out[0].conc_mass_phase_comp["Liq", "dye"] | ||
| # ) | ||
| # print(f"GAC outlet dye concentration is {outlet_dye}") | ||
| # solution_volume = value( | ||
| # m.fs.gac.process_flow.properties_in[0].flow_vol_phase["Liq"] | ||
| # * m.fs.gac.operational_time | ||
| # ) | ||
| # adsorbent_mass = value( | ||
| # m.fs.gac.process_flow.properties_in[0].flow_mass_phase_comp["Liq", "dye"] | ||
| # * m.fs.gac.operational_time | ||
| # ) | ||
| # adsorption_capacity = ( | ||
| # 100 * (inlet_dye - outlet_dye) * solution_volume / adsorbent_mass | ||
| # ) | ||
| # print(f"GAC adsorption capacity is {adsorption_capacity} %") | ||
|
|
||
| # ro_elec = value(m.fs.ro_costing.aggregate_flow_costs["electricity"]) | ||
| # zo_elec = value(m.fs.zo_costing.aggregate_flow_costs["electricity"]) | ||
| # | ||
| # print(f"RO Electricity: {ro_elec}") | ||
| # print(f"ZO Electricity: {zo_elec}") | ||
| # | ||
| # ro_vopex = value(m.fs.ro_costing.total_variable_operating_cost) | ||
| # zo_vopex = value(m.fs.zo_costing.total_variable_operating_cost) | ||
| # | ||
| # print(f"RO VOPEX: {ro_vopex}") # aggregate flow costs (electricity) | ||
| # print(f"ZO VOPEX: {zo_vopex}") | ||
| # | ||
| # ro_fopex = value(m.fs.ro_costing.total_fixed_operating_cost) | ||
| # zo_fopex = value(m.fs.zo_costing.total_fixed_operating_cost) | ||
| # | ||
| # print(f"RO FOPEX: {ro_fopex}") # MLC + aggregate fixed operating costs (unit model dependent) | ||
| # print(f"ZO FOPEX: {zo_fopex}") | ||
| # | ||
| # ro_mlc = value(m.fs.ro_costing.maintenance_labor_chemical_operating_cost) | ||
| # zo_mlc = value(m.fs.zo_costing.maintenance_labor_chemical_operating_cost) | ||
| # | ||
| # print(f"RO MLC: {ro_mlc}") | ||
| # print(f"ZO MLC: {zo_mlc}") |
There was a problem hiding this comment.
Do we need to keep this around ?
There was a problem hiding this comment.
Nope - I'll get rid of this
adam-a-a
approved these changes
Dec 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
Builds off #1485 to update various parameters values based on feedback.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: