Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED Cost Documentation #1454

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

#1360

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR labels Jun 26, 2024
@MarcusHolly MarcusHolly self-assigned this Jun 26, 2024
@MarcusHolly MarcusHolly mentioned this pull request Jun 26, 2024
28 tasks
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (7d4cf6e) to head (620c7dd).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         310      310           
  Lines       33206    33206           
=======================================
  Hits        31194    31194           
  Misses       2012     2012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusHolly MarcusHolly marked this pull request as ready for review June 26, 2024 18:59
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 27, 2024 04:08
@lbianchi-lbl lbianchi-lbl merged commit 3785348 into watertap-org:main Jun 27, 2024
24 checks passed
@lbianchi-lbl lbianchi-lbl added the 1.0 Hard requirement for the 1.0 release label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants