-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowsheet documentation for RO w/ ERD #1446
Flowsheet documentation for RO w/ ERD #1446
Conversation
docs/technical_reference/flowsheets/RO_with_energy_recovery.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/RO_with_energy_recovery.rst
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 310 310
Lines 33206 33206
=======================================
Hits 31194 31194
Misses 2012 2012 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things to address, but otherwise LGTM
docs/technical_reference/flowsheets/RO_with_energy_recovery.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/RO_with_energy_recovery.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kurbansitterley @adam-a-a FYI here's how I solved the merge conflict in the index page, let me know if something doesn't look right: |
Fixes/Resolves:
RO w/ ERD flowsheet documentation for #1219
Summary/Motivation:
Add flowsheet documentation for
RO_with_energy_recovery.py
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: