-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation for MD flowsheet #1444
add documentation for MD flowsheet #1444
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 310 310
Lines 33206 33206
=======================================
Hits 31194 31194
Misses 2012 2012 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one last typo, LGTM
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly formatting changes in a table, I made suggestions where possible.
Only one clarifying question at the end.
"**Pumps**" | ||
"Efficiency", "0.8", "dimensionless" | ||
"**Heater**" | ||
"Maximum outlet temperature", "90", "°C" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Maximum outlet temperature", "90", "°C" | |
"Maximum outlet temperature", "363", ":math:`\text{K}`" |
oops didn't realize Adam approved while I was reviewing. |
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
Co-authored-by: Kurban Sitterley <kurban.sitterley@nrel.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addresses #1219 for MD
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: