Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ZO Files #1438

Merged
merged 36 commits into from
Jun 28, 2024
Merged

Conversation

MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Jun 15, 2024

Fixes/Resolves:

Issue #1248

Changes proposed in this PR:

  • Deletes ZO flowsheets, which will be archived in a separate repo
  • Changes flowsheet directory from watertap/examples/flowsheets to watertap/flowsheets
  • Updates various imports and hard-coded file locations

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this Jun 15, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (a5103f3) to head (8fa61bd).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...wsheets/crystallization/sim_simple_crystallizer.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   93.94%   93.67%   -0.27%     
==========================================
  Files         310      285      -25     
  Lines       33206    30572    -2634     
==========================================
- Hits        31194    28638    -2556     
+ Misses       2012     1934      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusHolly MarcusHolly changed the title Delete ZO Flowsheets Delete ZO Files Jun 20, 2024
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR 1.0 Hard requirement for the 1.0 release labels Jun 20, 2024
@ksbeattie ksbeattie mentioned this pull request Jun 20, 2024
10 tasks
@MarcusHolly MarcusHolly marked this pull request as ready for review June 21, 2024 19:23
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can accept deleting the flowsheets, though I see it as unnecessary without bringing any positive outcomes.

However, I disagree with removing docs, yamls, and unit models associated with IEDO work. Why would we do this and yet keep all of the other ZO work associated with the WaterTAP3 migration?

@lbianchi-lbl lbianchi-lbl merged commit ef16eaa into watertap-org:main Jun 28, 2024
25 of 26 checks passed
lbianchi-lbl added a commit to lbianchi-lbl/watertap-ui that referenced this pull request Jun 29, 2024
This was referenced Jun 30, 2024
lbianchi-lbl added a commit to watertap-org/idaes-flowsheet-processor-ui that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants