-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete ZO Files #1438
Delete ZO Files #1438
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
- Coverage 93.94% 93.67% -0.27%
==========================================
Files 310 285 -25
Lines 33206 30572 -2634
==========================================
- Hits 31194 28638 -2556
+ Misses 2012 1934 -78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can accept deleting the flowsheets, though I see it as unnecessary without bringing any positive outcomes.
However, I disagree with removing docs, yamls, and unit models associated with IEDO work. Why would we do this and yet keep all of the other ZO work associated with the WaterTAP3 migration?
…lly/watertap into reorganize_case_studies
This reverts commit be6cd3d.
This reverts commit 5b3807c.
This reverts commit 88d4d9a.
Fixes/Resolves:
Issue #1248
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: