-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GreyBoxBlocks with cyipopt-watertap #1434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
===========================================
+ Coverage 41.22% 93.94% +52.71%
===========================================
Files 97 310 +213
Lines 10599 33206 +22607
===========================================
+ Hits 4369 31194 +26825
+ Misses 6230 2012 -4218 ☔ View full report in Codecov by Sentry. |
* enable GreyBoxBlocks with cyipopt-watertap * add failing cyipopt test * xfail-ing scaling test
Fixes/Resolves: N/A
Summary/Motivation:
We have an emerging need to use GreyBox models with WaterTAP. This PR would modify our cyipopt wrapper so that GreyBoxBlocks work correctly. This necessitates making a few other changes to the solver wrapper, including bring into WaterTAP the IDAES jacobian scaling so that we can utilize a custom-built PyomoNLP object when we have a model with GreyBoxBlocks.
Changes proposed in this PR:
PyomoNLP
objectscyipopt-watertap
.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: