Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Units from Report Strings #1428

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

MarcusHolly
Copy link
Contributor

Summary/Motivation:

Gets rid of units that are explicitly stated in the strings of reports

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added Priority:Normal Normal Priority Issue or PR 1.0 Hard requirement for the 1.0 release labels Jun 6, 2024
@MarcusHolly MarcusHolly self-assigned this Jun 6, 2024
Copy link
Contributor

@kurbansitterley kurbansitterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the change to NF and should be good

watertap/unit_models/nanofiltration_DSPMDE_0D.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kurbansitterley kurbansitterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy enough, LGTM

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.94%. Comparing base (cb76180) to head (55191af).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
watertap/unit_models/nanofiltration_DSPMDE_0D.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files         311      311           
  Lines       33151    33151           
=======================================
  Hits        31143    31143           
  Misses       2008     2008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimBartholomew TimBartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bknueven bknueven enabled auto-merge (squash) June 21, 2024 16:10
@bknueven bknueven merged commit 1044aed into watertap-org:main Jun 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants