Flowsheet documentation for seawater RO desalination #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use unit model docs from #1408 for table 1 in this doc. |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 310 310
Lines 33143 33143
=======================================
Hits 31133 31133
Misses 2010 2010 ☔ View full report in Codecov by Sentry. |
21 tasks
MarcusHolly
reviewed
Jun 5, 2024
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
MarcusHolly
reviewed
Jun 20, 2024
Comment on lines
18
to
41
| WaterTAP costing package | ||
| * :doc:`/technical_reference/costing/watertap_costing` | ||
| Unit model costing packages | ||
| * :doc:`/technical_reference/costing/detailed_unit_model_costing` | ||
| Zero order unit and costing models | ||
| * :doc:`/technical_reference/unit_models/zero_order_unit_models/index` | ||
| Zero order costing package | ||
| * :doc:`/technical_reference/costing/zero_order_costing` | ||
| Zero order property package | ||
| * :doc:`/technical_reference/core/water_props` | ||
| Seawater property package | ||
| * :doc:`/technical_reference/property_models/seawater` | ||
| Reverse osmosis model | ||
| * :doc:`/technical_reference/unit_models/reverse_osmosis_0D` | ||
| Pressure exchanger model | ||
| * :doc:`/technical_reference/unit_models/pressure_exchanger` | ||
| IDAES Translator blocks | ||
| * :doc:`idaes:reference_guides/model_libraries/generic/unit_models/translator` | ||
| IDAES Product blocks | ||
| * :doc:`idaes:reference_guides/model_libraries/generic/unit_models/product` | ||
| IDAES Separator blocks | ||
| * :doc:`idaes:reference_guides/model_libraries/generic/unit_models/separator` | ||
| IDAES Mixer blocks | ||
| * :doc:`idaes:reference_guides/model_libraries/generic/unit_models/mixer` |
There was a problem hiding this comment.
I feel like this section is a bit intimidating to look at lol. Maybe just group some of these together like:
Costing Packages
- WaterTAP Costing
- ZO Costing
- Unit Model Costing
Unit Models
- Mixer...
There was a problem hiding this comment.
Yeah agreed and good idea
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
docs/technical_reference/flowsheets/seawater_RO_desalination.rst
Outdated
Show resolved
Hide resolved
Comment on lines
+230
to
+236
| .. note:: | ||
|
|
||
| :sup:`1` TDS = total dissolved solids | ||
| | | ||
| :sup:`2` TSS = total suspended solids | ||
| | | ||
| :sup:`3` UV = Ultraviolet; AOP = Advanced oxidation process |
There was a problem hiding this comment.
I like how you formatted this!
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
TimBartholomew
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
Seawater RO desalination flowsheet documentation for #1219
Summary/Motivation:
Add flowsheet documentation for
seawater_RO_desalination.pyChanges proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: