Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idaes-pse requirement in preparation to 2.5 release #1421

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (6ef2765) to head (4fdc23d).
Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files         335      335           
  Lines       35572    35572           
=======================================
  Hits        33444    33444           
  Misses       2128     2128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review June 1, 2024 00:06
@lbianchi-lbl lbianchi-lbl added Priority:High High Priority Issue or PR PrOMMiS IDAES labels Jun 6, 2024
@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 6, 2024 23:44
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit ac10b0e into watertap-org:main Jun 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDAES Priority:High High Priority Issue or PR PrOMMiS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants