Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Costing Documentation #1395

Merged
merged 9 commits into from
May 22, 2024

Conversation

MarcusHolly
Copy link
Contributor

Fixes/Resolves:

Issue #1360

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly self-assigned this May 20, 2024
@MarcusHolly MarcusHolly mentioned this pull request May 20, 2024
28 tasks
@MarcusHolly MarcusHolly added documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR 1.0 Hard requirement for the 1.0 release labels May 20, 2024
@MarcusHolly MarcusHolly marked this pull request as ready for review May 20, 2024 13:57
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (abe21bc) to head (f5ef4cf).
Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files         335      335           
  Lines       35620    35620           
=======================================
  Hits        33456    33456           
  Misses       2164     2164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusHolly
Copy link
Contributor Author

Note to reviewers: If you happen to know where the unit model costing data came from for ERD, nanofiltration, pressure exchanger, pump, or RO, let me know and I can add the reference(s) to the documentation. Otherwise, we can just merge these in without references.

@savannahsakhai savannahsakhai self-requested a review May 20, 2024 19:27
Copy link
Contributor

@savannahsakhai savannahsakhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bknueven bknueven enabled auto-merge (squash) May 22, 2024 00:33
@bknueven bknueven merged commit 09d6964 into watertap-org:main May 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants