-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add More Costing Documentation #1395
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 335 335
Lines 35620 35620
=======================================
Hits 33456 33456
Misses 2164 2164 ☔ View full report in Codecov by Sentry. |
Note to reviewers: If you happen to know where the unit model costing data came from for ERD, nanofiltration, pressure exchanger, pump, or RO, let me know and I can add the reference(s) to the documentation. Otherwise, we can just merge these in without references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes/Resolves:
Issue #1360
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: