Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crystallizer costing documentation #1391

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

OOAmusat
Copy link
Contributor

@OOAmusat OOAmusat commented May 15, 2024

Fixes/Resolves:

Crystallizer costing documentation for #1360

@OOAmusat OOAmusat mentioned this pull request May 15, 2024
28 tasks
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (767910c) to head (804f024).
Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files         335      335           
  Lines       35620    35620           
=======================================
  Hits        33456    33456           
  Misses       2164     2164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one very minor typo

docs/technical_reference/costing/crystallizer.rst Outdated Show resolved Hide resolved
Co-authored-by: MarcusHolly <96305519+MarcusHolly@users.noreply.github.com>
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label May 16, 2024
Copy link
Contributor

@savannahsakhai savannahsakhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dangunter dangunter enabled auto-merge May 21, 2024 18:29
@dangunter dangunter merged commit d634915 into main May 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants