Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI for Extended BSM2 Flowsheet #1357

Merged
merged 8 commits into from
May 2, 2024

Conversation

MarcusHolly
Copy link
Contributor

@MarcusHolly MarcusHolly commented Apr 11, 2024

Summary/Motivation:

Adds GUI for the BSM2_P_extension.py flowsheet and adds costing into the conventional BSM2 GUI.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added the Priority:Normal Normal Priority Issue or PR label Apr 11, 2024
@MarcusHolly MarcusHolly self-assigned this Apr 11, 2024
@MarcusHolly MarcusHolly marked this pull request as ready for review April 12, 2024 19:05
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- I thought that costing was added to the extended bsm2 flowsheet but unsure. If so, I assume you opted not to add costing to the extended gui yet due to lack of effluent limits. Is that right?

@MarcusHolly
Copy link
Contributor Author

Extended BSM2 doesn't currently have costing or the effluent violations. I suppose costing could be added now, but I believe the effluent violations requires diving a bit more into the literature.

@ksbeattie ksbeattie enabled auto-merge (squash) May 2, 2024 20:28
@ksbeattie ksbeattie merged commit e29daf5 into watertap-org:main May 2, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants