-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI for Extended BSM2 Flowsheet #1357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- I thought that costing was added to the extended bsm2 flowsheet but unsure. If so, I assume you opted not to add costing to the extended gui yet due to lack of effluent limits. Is that right?
Extended BSM2 doesn't currently have costing or the effluent violations. I suppose costing could be added now, but I believe the effluent violations requires diving a bit more into the literature. |
Summary/Motivation:
Adds GUI for the
BSM2_P_extension.py
flowsheet and adds costing into the conventional BSM2 GUI.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: