-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement get_solver
for WaterTAP
#1353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarciadiego
approved these changes
Apr 10, 2024
TimBartholomew
approved these changes
Apr 11, 2024
lbianchi-lbl
pushed a commit
to watertap-org/parameter-sweep
that referenced
this pull request
May 1, 2024
* implement new get_solver for watertap * remove code which changes the idaes default solver * update watertap with new get_solver function * fix ASM2D flowsheet * fix MVC single stage * fix electrodialysis 1stack
lbianchi-lbl
pushed a commit
to watertap-org/watertap-solvers
that referenced
this pull request
Dec 7, 2024
* implement new get_solver for watertap * remove code which changes the idaes default solver * update watertap with new get_solver function * fix ASM2D flowsheet * fix MVC single stage * fix electrodialysis 1stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348
Summary/Motivation:
Presently, when
import watertap
runs we change the IDAES default to utilize theipopt-watertap
solver. This can mess with down stream projects as it is a side-effect of importing WaterTAP, e.g., prommis/prommis#52.This PR would remove this behavior, and replace it with WaterTAP's own implementation of
get_solver
which works identically to the IDAES version except it returnsipopt-watertap
by default.However, as a consequence, the behavior of
get_solver
within IDAES has changed for WaterTAP -- it now gets the IDAES defaults when imported fromidaes.core.solvers
. As a result, we would need to specify theipopt-watertap
solver when calling certain IDAES methods, e.g., f5a55cc, to get theipopt-watertap
solver for initialization. Usually this does not matter, but this PR would make this change on flowsheets that fail withoutipopt-watertap
for unit model initialization.Changes proposed in this PR:
get_solver
method for WaterTAP (e8d7b85)ipopt-watertap
(510b948)get_solver
towatertap.core.solvers
(f628c03)Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: