Minor Dye Desalination Flowsheet Updates

[MarcusHolly]

Fixes/Resolves:

Resolves various comments pointed out in #1294; namely:

• Replacing instances of .value with value()
• Adding a product block to reduce the number of if-statements
• Add config option for toggling between 1DRO and 0DRO

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[MarcusHolly]

I have not combined the dye_desalination_withRO.py and dye_desalination.py flowsheets in this PR (i.e. merging into one flowsheet that has a configuration option to include the RO treatment train). I've started implementing this change locally, but it's a bigger hassle than I initially thought - mainly because modifying the costing is a pain. So perhaps this smaller PR can be merged first and a subsequent PR will focus on combining the two flowsheets (it should also be easier to review this way).

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.84%. Comparing base (11705cb) to head (4b55be3).

Files	Patch %	Lines
...covery/dye_desalination/dye_desalination_withRO.py	90.90%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   93.85%   93.84%   -0.01%     
==========================================
  Files         337      337              
  Lines       35289    35290       +1     
==========================================
  Hits        33119    33119              
- Misses       2170     2171       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hunterbarber]

Changes are all very minor so LGTM. I would maybe still bullet the naming conventions, conversion to pyo.value() and other changes in the PR describtion for clarity.

[adam-a-a]

LGTM - I think we can rethink little bits here and there, but we can aim to polish on subsequent PR that combines both flowsheets (with and without RO).