Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete sw prop files #1347

Merged
merged 9 commits into from
Mar 29, 2024
Merged

delete sw prop files #1347

merged 9 commits into from
Mar 29, 2024

Conversation

adam-a-a
Copy link
Contributor

@adam-a-a adam-a-a commented Mar 29, 2024

Part of #1248

Summary/Motivation:

Remove seawater ion prop pack and seawater ion generic configuration file that was used for IDAES modular property model.

Changes proposed in this PR:

  • remove simple seawater ion prop model and config along with associated usages

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adam-a-a adam-a-a marked this pull request as ready for review March 29, 2024 15:28
@adam-a-a adam-a-a self-assigned this Mar 29, 2024
@adam-a-a adam-a-a added the low effort/low impact Low effort, low impact-- indicating low priority label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (abf7614) to head (7e68581).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   93.80%   93.85%   +0.04%     
==========================================
  Files         339      337       -2     
  Lines       35512    35289     -223     
==========================================
- Hits        33313    33119     -194     
+ Misses       2199     2170      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bknueven bknueven enabled auto-merge (squash) March 29, 2024 16:07
@bknueven bknueven merged commit 11705cb into watertap-org:main Mar 29, 2024
24 checks passed
@bknueven bknueven mentioned this pull request Mar 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low effort/low impact Low effort, low impact-- indicating low priority spring-cleaning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants