Making sure the MultiprocessingParallelManager cleans up when done #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbianchi-lbl
approved these changes
Nov 21, 2023
k1nshuk
approved these changes
Nov 21, 2023
|
I am going to adjust the semantics of this to make it identical in behavior to the prior implementation. |
|
@watertap-org/parameter-sweep just testing team notifications for the newly created https://github.com/orgs/watertap-org/teams/parameter-sweep org team. |
This reverts commit 5354b17.
|
The timeout tests are run here: https://github.com/bknueven/watertap/actions/runs/6948646192?pr=17. c241426 takes a much different approach and doesn't change the core algorithm. But I think it does address the issue. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
+ Coverage 91.21% 94.91% +3.70%
==========================================
Files 343 344 +1
Lines 34900 34919 +19
==========================================
+ Hits 31834 33144 +1310
+ Misses 3066 1775 -1291 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
approved these changes
Nov 21, 2023
lbianchi-lbl
added a commit
to watertap-org/parameter-sweep
that referenced
this pull request
May 1, 2024
…atertap-org/watertap#1211) * Try adding explicit timeout where possible/easy * Try one more timeout * Add quick n dirty way to shut down multiprocessing worker processes * Try using EAFP instead of checking Queue.empty() * Make timeout configurable with default value * Refactor to use logging * Reorder imports * remove timeout from concurrent.futures.wait * trying Pool implementation * Revert "trying Pool implementation" This reverts commit 5354b1794ae1195b1f9222f723e141908d7cfc76. * try using kill * pylint --------- Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves: #1158
Summary/Motivation:
See #1158. This will call
killto clean up any hangingProcesses at the end of the run using theMultiprocessingParallelManager.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: