Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting documentation typo for loopTool code block #1205

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Correcting documentation typo for loopTool code block #1205

merged 3 commits into from
Nov 16, 2023

Conversation

hunterbarber
Copy link
Contributor

@hunterbarber hunterbarber commented Nov 16, 2023 •
edited
Loading

Fixes/Resolves:

Found some typos to recently added documentation

Summary/Motivation:

Correcting documentation

Changes proposed in this PR:

  • Minor correction to typo

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@hunterbarber hunterbarber added documentation Improvements or additions to documentation Priority:Low Low Priority Issue or PR labels Nov 16, 2023
@hunterbarber hunterbarber self-assigned this Nov 16, 2023
lbianchi-lbl
lbianchi-lbl reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of additional typos caught my eye.

docs/how_to_guides/how_to_use_loopTool_to_explore_flowsheets.rst Outdated Show resolved Hide resolved
docs/how_to_guides/how_to_use_loopTool_to_explore_flowsheets.rst Outdated Show resolved Hide resolved
@hunterbarber @lbianchi-lbl
Apply suggestions from code review
c968dc4 
Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
@hunterbarber
Copy link
Contributor Author

A couple of additional typos caught my eye.

Thanks, I may as well do a larger review of this to see if I can find anymore before merging

adam-a-a
adam-a-a approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Nov 16, 2023 •
edited
Loading

The in-progress checks are most likely stuck because of #1158. Since the other tests are passing (and the changes only affect the docs anyway) I'm merging this in.

image

@lbianchi-lbl lbianchi-lbl merged commit 7768574 into watertap-org:main Nov 16, 2023
@hunterbarber hunterbarber deleted the doc_typo branch December 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@agarciadiego agarciadiego agarciadiego approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

@avdudchenko avdudchenko Awaiting requested review from avdudchenko

@MarcusHolly MarcusHolly Awaiting requested review from MarcusHolly MarcusHolly is a code owner

@luohezhiming luohezhiming Awaiting requested review from luohezhiming

@ElmiraShamlou ElmiraShamlou Awaiting requested review from ElmiraShamlou

Assignees

@hunterbarber hunterbarber

Labels
documentation Improvements or additions to documentation Priority:Low Low Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hunterbarber @lbianchi-lbl @adam-a-a @agarciadiego