-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models to add to the UI #1117
Comments
@adam-a-a @TimBartholomew So I have a surrogate that reduces the parameter input for the CPHSDM GAC model. In all it adds two surrogate constraints to replace 7 parameters obtained from a lookup table. I think the plan is that once the corresponding manuscript is submitted/published, to add those surrogates as an config option to the model. With the GUI models, I'm assuming lower parameter input is preferred. Should the GAC hold off until the surrogates have been implemented in main or should the GAC model for the GUI include these parameters that are readily available, but need looked up in literature as a function of other values in the model? |
@dangunter do you want to split apart the issues that will be in the March release into a separate issue and close this one for the Dec release? |
@hunterbarber I think the UI should have the 7 parameters (the As and Bs I am assuming) with defaults in there. Later we could think about adding the option to switch to a custom surrogate, with yours surrogates being the default forms. |
Are they not already provided? watertap/examples/flowsheets/gac/gac_ui.py#L601 And I agree I think that is the plan once those surrogates are added to the repo |
Sorry, this was my response to your previous comment that you posted back in November. I realized afterwards that your question was already resolved and the GAC UI was merged. |
Description
List of flowsheets to "wrap" so they can be accessed through the UI
Motivation
Need POC and flowsheet locations. Will need help choosing list of variables, etc.
Possible Implementation
No response
Additional Context
Wishlist
In order of priority
UI questions
The text was updated successfully, but these errors were encountered: