Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models to add to the UI #1117

Closed
6 of 8 tasks
dangunter opened this issue Aug 31, 2023 · 5 comments · Fixed by #1439
Closed
6 of 8 tasks

Models to add to the UI #1117

dangunter opened this issue Aug 31, 2023 · 5 comments · Fixed by #1439
Assignees
Labels
1.0 Hard requirement for the 1.0 release enhancement New feature or request Priority:High High Priority Issue or PR

Comments

@dangunter
Copy link
Collaborator

dangunter commented Aug 31, 2023

Description

List of flowsheets to "wrap" so they can be accessed through the UI

Motivation

Need POC and flowsheet locations. Will need help choosing list of variables, etc.

Possible Implementation

No response

Additional Context

  • Models that are currently UI-enabled are not as interesting/complex as others we have
  • Therefore, we want to have more of the complex models (FIXME) to become UI-enabled to showcase the full potential of the GUI

Wishlist

In order of priority

UI questions

  • Once we have these in, is there a way to group/identify/hide the simpler (current) models?
    • @MichaelPesce: working on categories
    • @adam-a-a what about "desalination & wastewater treatment"? or "detailed" and "simple"?
@dangunter dangunter added the enhancement New feature or request label Aug 31, 2023
@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Aug 31, 2023
@MarcusHolly MarcusHolly mentioned this issue Oct 30, 2023
@hunterbarber
Copy link
Contributor

@adam-a-a @TimBartholomew So I have a surrogate that reduces the parameter input for the CPHSDM GAC model. In all it adds two surrogate constraints to replace 7 parameters obtained from a lookup table. I think the plan is that once the corresponding manuscript is submitted/published, to add those surrogates as an config option to the model. With the GUI models, I'm assuming lower parameter input is preferred. Should the GAC hold off until the surrogates have been implemented in main or should the GAC model for the GUI include these parameters that are readily available, but need looked up in literature as a function of other values in the model?

@hunterbarber hunterbarber mentioned this issue Dec 6, 2023
6 tasks
@ksbeattie
Copy link
Contributor

@dangunter do you want to split apart the issues that will be in the March release into a separate issue and close this one for the Dec release?

@adam-a-a
Copy link
Contributor

@hunterbarber I think the UI should have the 7 parameters (the As and Bs I am assuming) with defaults in there. Later we could think about adding the option to switch to a custom surrogate, with yours surrogates being the default forms.

@hunterbarber
Copy link
Contributor

@hunterbarber I think the UI should have the 7 parameters (the As and Bs I am assuming) with defaults in there. Later we could think about adding the option to switch to a custom surrogate, with yours surrogates being the default forms.

Are they not already provided? watertap/examples/flowsheets/gac/gac_ui.py#L601 And I agree I think that is the plan once those surrogates are added to the repo

@adam-a-a
Copy link
Contributor

adam-a-a commented Mar 1, 2024

@hunterbarber I think the UI should have the 7 parameters (the As and Bs I am assuming) with defaults in there. Later we could think about adding the option to switch to a custom surrogate, with yours surrogates being the default forms.

Are they not already provided? watertap/examples/flowsheets/gac/gac_ui.py#L601 And I agree I think that is the plan once those surrogates are added to the repo

Sorry, this was my response to your previous comment that you posted back in November. I realized afterwards that your question was already resolved and the GAC UI was merged.

@ksbeattie ksbeattie added the 1.0 Hard requirement for the 1.0 release label Apr 18, 2024
@lbibl lbibl mentioned this issue Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release enhancement New feature or request Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants