Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working version of KBH MD #159

Open
wants to merge 4 commits into
base: kbhdp
Choose a base branch
from
+42 −39
Open

working version of KBH MD #159

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9017074
working version
Zhuoran29 Dec 20, 2024
1ccd748
uncomment lines
Zhuoran29 Dec 20, 2024
c26adbe
correct eqn
Zhuoran29 Dec 20, 2024
f095ce8
fix eqn
Zhuoran29 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/watertap_contrib/reflo/analysis/case_studies/KBHDP/components/MD.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def get_concentrate_flow(b):
return b.concentrate.properties[0].flow_vol_phase["Liq"] == pyunits.convert(
(
b.unit.mp.get_active_process_blocks()[-1].fs.vagmd.system_capacity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking on this. Is system capacity the volume of water (total feed) being treated or the volume of treated water produced (total permeate)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for spotting that, you're definitely correct (capacity = total permeate).
I just committed the correct equation, so that concentrate_volume = system_capacity * (1-recovery) / recovery

* m.water_recovery
* (1 - m.water_recovery)
# num_modules
# * blk.model_input["initial_batch_volume"]
# * pyunits.L
Expand Down