-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solar still ZLD unit model, costing model, test file #131
Merged
kurbansitterley
merged 49 commits into
watertap-org:main
from
kurbansitterley:solar_still
Dec 6, 2024
Merged
Add solar still ZLD unit model, costing model, test file #131
kurbansitterley
merged 49 commits into
watertap-org:main
from
kurbansitterley:solar_still
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
adam-a-a
reviewed
Nov 1, 2024
src/watertap_contrib/reflo/unit_models/tests/test_solar_still.py
Outdated
Show resolved
Hide resolved
adam-a-a
reviewed
Nov 1, 2024
src/watertap_contrib/reflo/unit_models/tests/test_solar_still.py
Outdated
Show resolved
Hide resolved
adam-a-a
reviewed
Nov 1, 2024
src/watertap_contrib/reflo/unit_models/tests/test_solar_still.py
Outdated
Show resolved
Hide resolved
adam-a-a
reviewed
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of the ZLD solar still unit model and costing model provided by NMSU for the SETO project.
The unit model is relatively straight forward.
The most important parameter
water_yield
relies on user input for the weather file (.csv) and an external function inutil
to calculate the daily water yield. This value is used to set the model parameterwater_yield
.The model assumes:
properties_waste
)The test file tests against a case provided by the NMSU team.
The regular(non-ZLD) solar still model may be a separate PR. Documentation will also be a separate PR.
TODO