Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solar still ZLD unit model, costing model, test file #131

Merged
merged 49 commits into from
Dec 6, 2024

Conversation

kurbansitterley
Copy link
Contributor

@kurbansitterley kurbansitterley commented Oct 1, 2024

This PR adds an implementation of the ZLD solar still unit model and costing model provided by NMSU for the SETO project.

The unit model is relatively straight forward.
The most important parameter water_yield relies on user input for the weather file (.csv) and an external function in util to calculate the daily water yield. This value is used to set the model parameter water_yield.

The model assumes:

  • All of the salt is removed (goes to properties_waste)
  • All of the water that comes in goes out as product water (i.e., 100% recovery)

The test file tests against a case provided by the NMSU team.

The regular(non-ZLD) solar still model may be a separate PR. Documentation will also be a separate PR.

TODO

  • verify source and collection steps for weather data to ensure it is properly formatted. The external utility function for calculating water yield relies on a specific organization of columns.

@kurbansitterley kurbansitterley marked this pull request as ready for review November 20, 2024 00:35
@kurbansitterley kurbansitterley changed the title Add solar still unit model, costing model, test file Add solar still ZLD unit model, costing model, test file Dec 6, 2024
@kurbansitterley kurbansitterley merged commit f210133 into watertap-org:main Dec 6, 2024
18 checks passed
@kurbansitterley kurbansitterley deleted the solar_still branch December 10, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants