KBHDP RPT 3 #122
Merged
KBHDP RPT 3 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/watertap-seto into kbhdp-case-study-md
…r/watertap-seto into kbhdp-case-study-md
…r/watertap-seto into kbhdp-case-study-md
…r/watertap-seto into kbhdp-case-study-md
8 tasks
adam-a-a
reviewed
Dec 9, 2024
| @@ -0,0 +1,54 @@ | |||
| base_currency: USD_2021 | |||
There was a problem hiding this comment.
Suggested change
| base_currency: USD_2021 | |
| base_currency: USD_2023 |
adam-a-a
reviewed
Dec 9, 2024
src/watertap_contrib/reflo/data/technoeconomic/kbhdp_case_study.yaml
Outdated
Show resolved
Hide resolved
adam-a-a
reviewed
Dec 9, 2024
src/watertap_contrib/reflo/data/technoeconomic/kbhdp_case_study.yaml
Outdated
Show resolved
Hide resolved
adam-a-a
reviewed
Dec 9, 2024
Comment on lines
10
to
45
| # hydrogen_peroxide: | ||
| # value: 1.53 | ||
| # units: USD_2020/kg | ||
| # purity: 1 | ||
|
|
||
| # global_parameters: | ||
| # plant_lifetime: | ||
| # value: 30 | ||
| # units: year | ||
| # utilization_factor: | ||
| # value: 1 | ||
| # units: dimensionless | ||
| # land_cost_percent_FCI: | ||
| # value: 0.0015 | ||
| # units: dimensionless | ||
| # working_capital_percent_FCI: | ||
| # value: 0.05 | ||
| # units: dimensionless | ||
| # salaries_percent_FCI: | ||
| # value: 0.001 | ||
| # units: 1/year | ||
| # benefit_percent_of_salary: | ||
| # value: 0.9 | ||
| # units: dimensionless | ||
| # maintenance_costs_percent_FCI: | ||
| # value: 0.008 | ||
| # units: 1/year | ||
| # laboratory_fees_percent_FCI: | ||
| # value: 0.003 | ||
| # units: 1/year | ||
| # insurance_and_taxes_percent_FCI: | ||
| # value: 0.002 | ||
| # units: 1/year | ||
| # wacc: | ||
| # # Weighted Average Cost of Capital (WACC) | ||
| # value: 0.05 |
There was a problem hiding this comment.
Just to note what we said in our meeting, it might be best to be explicit about all of our parameter assumptions here in the yaml so that if things change later, we know we can rely on what values were set here for the case study. In other words, be explicit about base currency of 2023 even if that is set as the default somewhere else in the codebase.
adam-a-a
approved these changes
Dec 9, 2024
…y.yaml Co-authored-by: Adam Atia <aatia@keylogic.com>
…y.yaml Co-authored-by: Adam Atia <aatia@keylogic.com>
…ion for detailed output
…larity and performance; change base currency in YAML configuration
… into pr/MuktaHardikar/122
kurbansitterley
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic MD components files pending the merge of multiperiod VAGMD flowsheets PR