Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to stable versions of environment dependencies (Pyomo, PySAM) #115

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

kurbansitterley
Copy link
Contributor

All test will fail with current build from issues with both PySAM and Pyomo/IDAES/WaterTAP dependencies.

This PR reverts to pyomo==6.7.1 and nrel-pysam==5.1.0.

@kurbansitterley
Copy link
Contributor Author

@adam-a-a @zacharybinger @MuktaHardikar @Zhuoran29 trying to fix this issue and mentioning you just for visibility.

I think we can skip reviews here if all tests pass. Then we can get to other PRs.

@kurbansitterley kurbansitterley self-assigned this Jul 3, 2024
@kurbansitterley
Copy link
Contributor Author

I believe I fixed the nrel-pysam issue and pyomo issue, but now having this same problem: watertap-org/watertap#1440

@lbianchi-lbl
Copy link
Contributor

@kurbansitterley I'm in the process of cutting WaterTAP 1.0.0rc0, which supports IDAES 2.5.0 and Pyomo 6.7.3. I'll let you know once that's online, and then we can try to see if setting watertap>=1.0.0rc0 helps with these issues.

@kurbansitterley
Copy link
Contributor Author

@kurbansitterley I'm in the process of cutting WaterTAP 1.0.0rc0, which supports IDAES 2.5.0 and Pyomo 6.7.3. I'll let you know once that's online, and then we can try to see if setting watertap>=1.0.0rc0 helps with these issues.

Yes I presume that would fix all these issues, so I have been checking to see if the rc has been cut yet over the past hr or so. I appreciate your comment.

@lbianchi-lbl
Copy link
Contributor

@kurbansitterley 1.0.0rc0 is up: https://pypi.org/project/watertap/1.0.0rc0/ You should be able to pin the following dependencies, e.g.:

watertap>=1.0.0rc0
idaes-pse==2.5.0
pyomo==6.7.3

@kurbansitterley
Copy link
Contributor Author

Environment build is fixed, remaining failed tests should be addressed with #116 and #117

@kurbansitterley kurbansitterley merged commit cc17012 into watertap-org:main Jul 3, 2024
2 of 18 checks passed
@kurbansitterley kurbansitterley deleted the fix_reflo_setup branch December 10, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants