-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to stable versions of environment dependencies (Pyomo, PySAM) #115
Point to stable versions of environment dependencies (Pyomo, PySAM) #115
Conversation
@adam-a-a @zacharybinger @MuktaHardikar @Zhuoran29 trying to fix this issue and mentioning you just for visibility. I think we can skip reviews here if all tests pass. Then we can get to other PRs. |
I believe I fixed the nrel-pysam issue and pyomo issue, but now having this same problem: watertap-org/watertap#1440 |
@kurbansitterley I'm in the process of cutting WaterTAP 1.0.0rc0, which supports IDAES 2.5.0 and Pyomo 6.7.3. I'll let you know once that's online, and then we can try to see if setting |
Yes I presume that would fix all these issues, so I have been checking to see if the rc has been cut yet over the past hr or so. I appreciate your comment. |
@kurbansitterley 1.0.0rc0 is up: https://pypi.org/project/watertap/1.0.0rc0/ You should be able to pin the following dependencies, e.g.: watertap>=1.0.0rc0
idaes-pse==2.5.0
pyomo==6.7.3 |
All test will fail with current build from issues with both PySAM and Pyomo/IDAES/WaterTAP dependencies.
This PR reverts to pyomo==6.7.1 and nrel-pysam==5.1.0.