Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linux keyring failure #78

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix linux keyring failure #78

merged 3 commits into from
Sep 6, 2024

Conversation

shantanuraj
Copy link
Member

What does this PR do?

  • 🎩 Report underlying error when credential write or delete fails
  • 🔑 Enable linux-default-keyutils feature for keyring
  • keyring falls back to keyutils if secure-storage is not available
    image

Gif

disney-penguin

Context

@shantanuraj shantanuraj self-assigned this Sep 6, 2024
@shantanuraj shantanuraj force-pushed the shantanu/linux-keyring branch from e27da21 to a2f7c60 Compare September 6, 2024 09:17
@shantanuraj
🔑 Enable linux-default-keyutils feature for keyring
57ad2a7 
- Update keyring package.
- Fallsback to keyutils if secure storage cannot be accessed.
  Usually happens on headless environments or WSL on windows

  Context: Brooooooklyn/keyring-node#12

  Closes #72
@shantanuraj shantanuraj force-pushed the shantanu/linux-keyring branch from a2f7c60 to 57ad2a7 Compare September 6, 2024 09:18
@shantanuraj shantanuraj merged commit 9231805 into main Sep 6, 2024
5 checks passed
@shantanuraj shantanuraj deleted the shantanu/linux-keyring branch September 6, 2024 09:30
@shantanuraj shantanuraj mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shantanuraj shantanuraj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toggl auth fail
1 participant
@shantanuraj