Testing Maintenance tasks #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes automatically applied by using codespell through a pre-commit configuration: python -m pre_commit run --all-files
These were identified by codespell, but were unable to be auto fixed due to the inability to determine a fix with high confidence.
84a32e2 to
d9fcac8
Compare
This aims to reduce the number of diff changes included in commits that can obscure the important code change.
TotalSegmentator was officially marked as requiring Python 3.9+ in wasserth@5defa48. Changes automatically applied using: python -m pre_commit run --all-files
|
@wasserth This PR is ready for your review. |
|
I have a question: Linting and spell checking is now part of github/workflows and also part of pre-commit hooks. Is this redundant? |
|
Indeed. You could remove one of them. You could keep the separate workflow one if you want to have codespell have its own independent status check to merge a PR compared to other linting checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add some maintenance tasks.
Currently under testing. Will convert to draft once ready.Along with the introduction in
CI: Add Dependabot workflow to update GitHub actions, the admin should go to https://github.com/wasserth/TotalSegmentator/settings/security_analysis and enable "Dependabot alerts", "Dependabot security updates" and "Dependabot version updates". Once the workflow is added, it should automatically run dependabot for the first time and update outdated actions such asactions/checkoutwhich is now at v4:TotalSegmentator/.github/workflows/run_tests.yml
Line 14 in 127f243
The following commits include GitHub actions to find spelling mistakes along with the commits that include the auto-fixes.
Ultimately the GitHub actions here aim to point out various issues in an automated way to keep the repository well maintained.
jamesobutler#1 is the PR in my fork that showcases the workflows running successfully. At this moment this PR requires the maintainer @wasserth to approve the new workflows.
Following the integration of this PR a
.git-blame-ignore-revscan be committed to this repo specifying the integrated commit hashes of bulk change commits likeSTYLE: Trim trailing whitespaceso that it does not come up when git blaming to track down when a certain line was last edited.