Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license setting #208

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix license setting #208

merged 2 commits into from
Oct 24, 2023

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Oct 24, 2023

Fix some problems with license file setting (too short timeout and incorrect process exit code).

On some computers on some networks, license server query times out. Slightly increasing the timeout fixes the issue.
When the license setting process failed, the process still returned with success (exit code = 0).
This made it more difficult to detect a problem: the caller process had to parse the output text of the process.

Exit code is now set to non-zero value, so the caller process can detect errors without searching for specific text patterns.
@wasserth wasserth merged commit c695b4c into wasserth:master Oct 24, 2023
@lassoan
Copy link
Contributor Author

lassoan commented Oct 24, 2023

Thank you!

@lassoan lassoan deleted the fix-license-setting branch October 24, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants