Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: clear preservations when resetting register alloc #787

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.56ms 1.56ms 🔴 -0.14% 1.18ms 1.08ms 🟢 -9.06% 🟢 -31%
execute/
bare_call_0/typed
1.16ms 1.18ms 🔴 2.35% 781.59µs 757.30µs 🟢 -2.83% 🟢 -36%
execute/
bare_call_1
1.61ms 1.60ms 🟢 0.06% 1.39ms 1.27ms 🟢 -9.12% 🟢 -21%
execute/
bare_call_16
2.59ms 2.53ms 🟢 -1.98% 3.36ms 3.36ms ⚪ 0.00% 🟢 32%
execute/
bare_call_16/typed
1.55ms 1.55ms ⚪ -0.21% 1.87ms 1.86ms ⚪ -0.77% 🟢 20%
execute/
bare_call_1/typed
1.26ms 1.27ms ⚪ 0.55% 1.27ms 1.16ms 🟢 -9.33% 🟢 -9%
execute/
bare_call_4
1.76ms 1.77ms 🔴 0.36% 1.76ms 1.60ms 🟢 -9.24% 🟢 -10%
execute/
bare_call_4/typed
1.21ms 1.23ms 🔴 1.69% 1.11ms 1.05ms 🟢 -5.65% 🟢 -15%
execute/
br_table
1.35ms 1.38ms 🔴 1.99% 1.27ms 1.27ms ⚪ -0.62% 🟢 -8%
execute/
count_until
620.41µs 620.74µs ⚪ 0.15% 1.30ms 1.32ms ⚪ 0.95% 🔴 112%
execute/
factorial_iterative
319.00µs 319.50µs ⚪ 0.11% 577.45µs 578.54µs ⚪ -0.01% 🟡 81%
execute/
factorial_recursive
491.10µs 494.99µs ⚪ 0.78% 749.56µs 760.41µs 🔴 1.49% 🟡 54%
execute/
fibonacci_iter
1.75ms 1.40ms 🟢 -19.99% 2.78ms 2.90ms 🔴 4.17% 🔴 107%
execute/
fibonacci_rec
3.97ms 3.97ms ⚪ -0.18% 6.70ms 6.74ms ⚪ 0.49% 🟡 70%
execute/
fibonacci_tail
856.53µs 858.02µs ⚪ 0.16% 1.64ms 1.69ms 🔴 3.35% 🟡 97%
execute/
global_bump
747.84µs 747.73µs ⚪ -0.02% 1.68ms 1.69ms ⚪ 0.00% 🔴 127%
execute/
global_const
659.06µs 658.81µs ⚪ -0.04% 1.34ms 1.38ms 🔴 2.62% 🔴 109%
execute/
host_calls
36.82µs 37.30µs ⚪ 1.73% 41.55µs 38.66µs 🟢 -6.99% 🟢 4%
execute/
memory_fill
1.17ms 1.15ms ⚪ -1.56% 2.45ms 2.38ms 🟢 -2.86% 🔴 107%
execute/
memory_sum
1.14ms 1.14ms ⚪ 1.73% 2.40ms 2.42ms ⚪ 0.94% 🔴 112%
execute/
memory_vec_add
2.35ms 2.47ms 🔴 5.05% 5.26ms 5.28ms ⚪ 0.29% 🔴 114%
execute/
recursive_is_even
664.68µs 664.83µs ⚪ 0.03% 1.12ms 1.14ms 🔴 1.76% 🟡 71%
execute/
recursive_ok
94.35µs 95.75µs ⚪ 1.05% 170.37µs 171.15µs ⚪ 0.46% 🟡 79%
execute/
recursive_scan
129.53µs 129.90µs ⚪ 0.08% 228.49µs 228.38µs ⚪ -0.18% 🟡 76%
execute/
recursive_trap
8.79µs 8.85µs ⚪ 0.93% 17.13µs 17.16µs ⚪ 0.09% 🟡 94%
execute/
regex_redux
456.68µs 459.91µs ⚪ 0.92% 934.99µs 902.56µs 🟢 -3.58% 🟡 96%
execute/
rev_complement
425.52µs 421.45µs ⚪ -0.96% 864.61µs 870.60µs ⚪ 0.58% 🔴 107%
execute/
tiny_keccak
317.89µs 322.32µs 🔴 1.56% 669.68µs 702.84µs 🔴 4.94% 🔴 118%
execute/
trunc_f2i
738.70µs 738.35µs ⚪ -0.15% 1.70ms 1.74ms 🔴 2.33% 🔴 136%
instantiate/
wasm_kernel
54.22µs 57.22µs 🔴 5.10% 58.12µs 52.11µs 🟢 -11.01% 🟢 -9%
translate/
erc1155
206.28µs 208.15µs ⚪ 0.92% 357.99µs 358.94µs ⚪ 0.50% 🟡 72%
translate/
erc20
103.04µs 102.87µs ⚪ -0.30% 173.15µs 174.11µs ⚪ 0.52% 🟡 69%
translate/
erc721
145.33µs 144.75µs ⚪ -0.34% 251.54µs 253.13µs ⚪ 0.61% 🟡 75%
translate/
spidermonkey
63.72ms 63.58ms ⚪ -0.36% 0.00ns 0.00ns 🔴 1.81% 🟢 -100%
translate/
wasm_kernel
4.17ms 4.15ms ⚪ 0.07% 6.43ms 6.52ms 🔴 1.37% 🟡 57%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7911bd2) 81.39% compared to head (fa2111e) 81.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   81.39%   81.40%   +0.01%     
==========================================
  Files         271      271              
  Lines       24235    24236       +1     
==========================================
+ Hits        19725    19730       +5     
+ Misses       4510     4506       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit d1bc10c into master Nov 19, 2023
13 checks passed
@Robbepop Robbepop deleted the rf-fix-reg-preservation-reuse-bug branch November 19, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants