Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wit): Updates wit package name and adds a version #23

Merged

Conversation

thomastaylor312
Copy link
Contributor

This also updates to use wkg.lock for the dependencies. Please note that if you need to update dependencies, make sure to use wash as it knows how to patch the wasi:logging dep to work properly

I'll open a PR after the new wash lands to update how to use the wit (including the name change) and updates the examples

@thomastaylor312 thomastaylor312 requested a review from a team as a code owner October 8, 2024 18:52
@thomastaylor312 thomastaylor312 force-pushed the feat/add_version_and_publish_wit branch from 5c9ebca to 68bd75f Compare October 8, 2024 18:58
.github/workflows/wit.yaml Outdated Show resolved Hide resolved
.github/workflows/wit.yaml Show resolved Hide resolved
@thomastaylor312 thomastaylor312 force-pushed the feat/add_version_and_publish_wit branch 2 times, most recently from c30184e to 7efa4d9 Compare October 8, 2024 19:08
This also updates to use wkg.lock for the dependencies. Please note that
if you need to update dependencies, make sure to use `wash` as it knows
how to patch the wasi:logging dep to work properly

I'll open a PR after the new wash lands to update how to use the wit (
including the name change) and updates the examples

Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
@thomastaylor312 thomastaylor312 force-pushed the feat/add_version_and_publish_wit branch from 7efa4d9 to 841995a Compare October 8, 2024 19:12
Copy link
Member

@joonas joonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@joonas
Copy link
Member

joonas commented Oct 8, 2024

I'm leaving this open in case @lxfontes has any additional feedback, I know he's bit more familiar with wkg than I am, so I wasn't sure if there was anything else we might want here?

@lxfontes lxfontes merged commit d90e203 into wasmCloud:main Oct 8, 2024
5 checks passed
@thomastaylor312 thomastaylor312 deleted the feat/add_version_and_publish_wit branch October 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants