Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI & !except snippets #5

Merged
merged 11 commits into from
Oct 4, 2021
Merged

Conversation

DeepQuantum
Copy link
Collaborator

I'm not quite sure if you only take suggestions for snippets or just allow user submitted ones, but I think these are quite useful for the 2.0 version of discord.py. If you like these snippets, I'm more than happy to help expand the UI category further.

Copy link
Owner

@wasi-master wasi-master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, here are some of the changes I would like.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
snippets/snippets.code-snippets Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Owner

@wasi-master wasi-master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I forgot to request changes in the previous one

DeepQuantum and others added 7 commits October 3, 2021 20:37
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
Co-authored-by: Wasi Master <63045920+wasi-master@users.noreply.github.com>
@DeepQuantum
Copy link
Collaborator Author

DeepQuantum commented Oct 3, 2021

Alright! I wasn't quite sure about the 1.5.0, but yes, I agree that it should be that. Also naming it !except makes a lot more sense. I think im gonna see next if i can do something useful with the discord.ui.View or add some other functionality from the 2.0 version. Thanks for approving !

Copy link
Owner

@wasi-master wasi-master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@wasi-master wasi-master merged commit 27efb1a into wasi-master:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants