Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wpds-assets #676

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: update wpds-assets #676

merged 2 commits into from
Dec 10, 2024

Conversation

artmsilva
Copy link
Contributor

@artmsilva artmsilva commented Dec 10, 2024

What I did

updates the washingtonpost logo https://github.com/washingtonpost/wpds-assets-manager/pull/220/files#diff-c40429ccb8bf629122e52f1105ff8c28653a7cb36c337d238c6f63450e8a3b36

test page

https://wpds-ui-kit-git-bump-kit.preview.now.washingtonpost.com/foundations/logos

scroll to washingtonpost logo (first one)
CleanShot 2024-12-10 at 12 31 30@2x

toggle theme - logo color should switch back and forth

@artmsilva artmsilva requested a review from a team as a code owner December 10, 2024 17:17
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
wpds-ui-kit ✅ Ready (Inspect) Visit Preview Dec 10, 2024 6:17pm
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview Dec 10, 2024 6:17pm

Copy link
Contributor

@luciovilla luciovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the WP logo with the white background doesnt change on dark mode:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants