Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update keyboard accessibility docs to correct keyDownButtonWrapper and add Firefox guidance #366

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: update keyboard accessibility docs to correct keyDownButtonWrapper and add Firefox guidance #366

merged 1 commit into from
Mar 31, 2023

Conversation

hs4man21
Copy link
Contributor

@hs4man21 hs4man21 commented Mar 31, 2023 •
edited
Loading

What I did

SRED-164

  • Our keyDownButtonWrapper was not handling space (" ") keys correctly. I fixed in spectrum and am updating here.
  • I also realized we could be providing guidance on how to enable keyboard navigation in Firefox on MacOS.

Check out the updated docs page.

@hs4man21 hs4man21 self-assigned this Mar 31, 2023
@hs4man21 hs4man21 requested a review from a team as a code owner March 31, 2023 19:25
@vercel
Copy link

vercel bot commented Mar 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
wpds-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 7:52PM (UTC)
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 7:52PM (UTC)
wpds-ui-kit-vitejs-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 7:52PM (UTC)
wpds-ui-kit-vitejs-v2-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 7:52PM (UTC)

artmsilva
artmsilva approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@artmsilva artmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hs4man21 hs4man21 merged commit 1b55621 into main Mar 31, 2023
@hs4man21 hs4man21 deleted the SRED-164 branch March 31, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artmsilva artmsilva artmsilva approved these changes

Assignees

@hs4man21 hs4man21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hs4man21 @artmsilva