feat: Switch component #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
build.washingtonpost.com/components/Markdown/Components/Anatomy.jsx
Outdated
Show resolved
Hide resolved
build.washingtonpost.com/components/Markdown/Components/Sandbox.js
Outdated
Show resolved
Hide resolved
build.washingtonpost.com/components/Markdown/Components/inlineSVG.js
Outdated
Show resolved
Hide resolved
build.washingtonpost.com/components/Markdown/Components/inlineSVG.js
Outdated
Show resolved
Hide resolved
|
|
||
| ### Error | ||
|
|
||
| When the switch is a requirement it will show an error border color. |
There was a problem hiding this comment.
This sentence doesn't seem correct. There's no visual indication that a switch is required per next section. You may have meant when a required switch hasn't been touched? or something like that?
There was a problem hiding this comment.
I used the copy from Zeplin. Def down to refine with design.
| ...Kit, | ||
| ...Assets, | ||
| // ...Assets, // this is causing the issue.. we have an icon named Switch and it's conflicting with the Switch component from WPDS UI Kit |
There was a problem hiding this comment.
I want to keep this comment so future us will know why.
artmsilva
commented
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
New Switch component!