Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using builder cache in integration tests #162

Merged

Conversation

mugdha-adhav
Copy link
Collaborator

Motivation

Closes #102

Suggested changes

Regarding this comment -

But instead of directly disabling caching, we should look into how we can enable smart caches where if the changes are detected in the code/tests only then the caching is disabled.

I tried checking if there's an easy way to enable smart caches, but couldn't find any easily configurable.

The easiest way I found to fix this is to cleanup docker builder, so that the same builder won't be used again.

Reproducing the issue

In the last few CI builds I found that the same builder was not being used in the consecutive builds. But there's a possibility of that happening if the same actions node is reused again.

I could reproduce the issue locally if the same builder is being used.

@mugdha-adhav mugdha-adhav requested a review from a team as a code owner August 29, 2024 07:32
@mugdha-adhav mugdha-adhav merged commit a30f32f into warm-metal:main Aug 29, 2024
7 checks passed
@mugdha-adhav mugdha-adhav deleted the fix/integration-test-cache branch August 29, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching in integration tests caused failures to be ignored
1 participant