rm template_id fields #840

mn13 · 2024-09-13T13:38:13Z

Cleanup missed template_id field from Key, Space and corresponding messages

Summary by CodeRabbit

New Features
- Introduced more granular control over template management for key requests and spaces with new fields for approval and rejection templates.
- Enhanced event emissions to reflect the new template structures.
- Updated the @wardenprotocol/wardenjs package to version 0.0.10.
Bug Fixes
- Simplified logic for handling template IDs in key and space updates, removing unnecessary validation checks.
Documentation
- Updated CHANGELOG to reflect significant modifications in the action management system and template handling.

coderabbitai · 2024-09-13T13:38:20Z

Walkthrough

The changes in this pull request focus on restructuring the action management system by removing certain template identifiers and renaming fields to enhance clarity. Key modifications include the removal of TemplateId, AdminTemplateId, and SignTemplateId, along with the introduction of new fields for approval and rejection processes. The updates span multiple files, impacting the handling of spaces, keys, and events, thereby streamlining the overall architecture of the system.

Changes

File Path	Change Summary
`CHANGELOG.md`	Removed `TemplateId` from `Key` and `AdminTemplateId`, `SignTemplateId` from `Space`. Renamed `Rule` to `Template` and removed `Template` and `Approvers` from `Action`.
`cmd/wardend/cmd/gen-spaces.go`	Updated `Space` struct to replace `AdminTemplateId` and `SignTemplateId` with `ApproveAdminTemplateId`, `RejectAdminTemplateId`, `ApproveSignTemplateId`, and `RejectSignTemplateId`.
`proto/warden/warden/v1beta3/events.proto`	Renamed template ID fields in event messages to reflect approval and rejection roles, enhancing clarity.
`proto/warden/warden/v1beta3/key.proto`	Modified `KeyRequest` and `Key` messages to include `approve_template_id` and `reject_template_id`, replacing the previous single `template_id` field.
`proto/warden/warden/v1beta3/space.proto`	Removed `admin_template_id` and `sign_template_id` fields from `Space`. Adjusted field indices accordingly.
`proto/warden/warden/v1beta3/tx.proto`	Updated message structures to replace old template ID fields with new approval and rejection fields across several messages (`MsgNewSpace`, `MsgUpdateSpace`, `MsgNewKeyRequest`, `MsgUpdateKey`).
`tests/cases/keychain_writers.go`	Removed `--template-id 0` parameter from key request command strings, indicating a shift in processing key requests.
`warden/app/wasm-interop/custom_msg.go`	Added `ApproveTemplateId` and `RejectTemplateId` to `NewKeyRequest` struct, replacing `TemplateId`. Updated message construction accordingly.
`warden/x/warden/keeper/key_requests.go`	Expanded `Key` struct to include `ApproveTemplateId` and `RejectTemplateId`, enhancing key request handling.
`warden/x/warden/keeper/msg_server_fulfil_key_request.go`	Added `ApproveTemplateId` and `RejectTemplateId` fields to the `EventNewKey` event for better tracking of key requests.
`warden/x/warden/keeper/msg_server_new_key_request.go`	Replaced `TemplateId` with `ApproveTemplateId` and `RejectTemplateId` in key request handling and event emission logic.
`warden/x/warden/keeper/msg_server_new_space.go`	Introduced new fields for approval and rejection templates in the `Space` struct, replacing previous template fields.
`warden/x/warden/keeper/msg_server_update_key.go`	Removed validation logic for `TemplateId` in `UpdateKey`, simplifying the update process.
`warden/x/warden/keeper/msg_server_update_space.go`	Removed validation for `AdminTemplateId` and `SignTemplateId` in `UpdateSpace`, while retaining it for approval templates, and updated event emissions accordingly.
`wardenjs/package.json`	Updated version number of `@wardenprotocol/wardenjs` package from "0.0.9" to "0.0.10".

Possibly related PRs

[x/act V2]: Add MsgVote handling #794: The changes in this PR involve enhancements to action handling based on voting outcomes, which may relate to the overall action management system discussed in the main PR.
Release wardenjs 0.0.9 #801: This PR includes updates to the changelog that reflect significant changes in the action management system, aligning with the modifications made in the main PR.
779 handle approve reject expressions #812: This PR introduces functionality for handling approval and rejection expressions, which connects to the changes in action processing in the main PR.
Сlean-ups after x/act updates #834: This PR reflects clean-ups and structural changes in action handling, particularly the removal of Template and Approvers, which directly relates to the changes made in the main PR.
833 wardenjs x/act 2 #839: This PR discusses significant modifications to the action management system, including the removal of Template and Approvers, which aligns with the main PR's focus on simplifying action structures.

Suggested labels

x-act

Tip

OpenAI O1 model for chat

We have deployed OpenAI's latest O1 model for chat.
OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
Please share any feedback with us in the discussions post.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba58c97 and e9186d6.

Files ignored due to path filters (80)

spaceward/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
wardenjs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
wardenjs/src/codegen/binary.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/auth/v1beta1/auth.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/base/abci/v1beta1/abci.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/base/query/v1beta1/pagination.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/base/tendermint/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/distribution/v1beta1/distribution.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/distribution/v1beta1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/distribution/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/module/v1/module.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1/gov.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1beta1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1beta1/gov.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/gov/v1beta1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/group/v1/events.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/group/v1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/group/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/group/v1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/group/v1/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/mint/v1beta1/mint.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/staking/v1beta1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/staking/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/staking/v1beta1/staking.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/tx/signing/v1beta1/signing.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/tx/v1beta1/service.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/tx/v1beta1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/upgrade/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/upgrade/v1beta1/upgrade.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/vesting/v1beta1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/cosmos/vesting/v1beta1/vesting.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/evm/v1/evm.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/evm/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/evm/v1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/feemarket/v1/feemarket.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/feemarket/v1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/feemarket/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/types/v1/indexer.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/ethermint/types/v1/web3.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/extern.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/google/protobuf/descriptor.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/helpers.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/index.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/json-safe.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/react-query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/marketmap/v1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/marketmap/v1/market.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/marketmap/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/oracle/v1/genesis.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/oracle/v1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/slinky/types/v1/currency_pair.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/abci/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/crypto/proof.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/libs/bits/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/p2p/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/types/evidence.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/types/params.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/types/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/types/validator.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/tendermint/version/types.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/utf8.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/varint.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/action.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/events.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/params.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/template.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/act/v1beta1/tx.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/gmp/gmp.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/events.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/key.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/keychain.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/query.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/signature.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/space.ts is excluded by !wardenjs/src/codegen/**
wardenjs/src/codegen/warden/warden/v1beta3/tx.ts is excluded by !wardenjs/src/codegen/**

Files selected for processing (1)

wardenjs/package.json (1 hunks)

Files skipped from review due to trivial changes (1)

wardenjs/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-09-13T13:40:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
warden-help-center	⬜️ Ignored (Inspect)	Visit Preview		Sep 13, 2024 2:00pm

artur-abliazimov · 2024-09-13T13:42:23Z

Let's also regenerate types in wardenjs.

coderabbitai

Actionable comments posted: 2

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5e145f1 and ba58c97.

Files ignored due to path filters (53)

api/warden/warden/v1beta3/events.pulsar.go is excluded by !api/**
api/warden/warden/v1beta3/key.pulsar.go is excluded by !api/**
api/warden/warden/v1beta3/space.pulsar.go is excluded by !api/**
api/warden/warden/v1beta3/tx.pulsar.go is excluded by !api/**
tests/testdata/snapshot-base/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/gentx/gentx-01e813234f9a16dfeed98b1c8df08ca4354ceaf5.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/gentx/gentx-85d1e2d789cdc74d572a48b6de76477d9d1d79c9.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/0c47f8d9d3647451f3afdc04d21d74a41f3bb505.address is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/alice.info is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/b0b3c0320eee612d53ee503b33d8aa26deaa7423.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/gentx/gentx-365bc73652207de103158c338b33962456430b20.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/gentx/gentx-fa2b60327a87cbf7e17430f62307b66404a431d6.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/25f15d556cc34510107fe3bc0116bcdff066affd.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/42bce85c5294ebed9d3ad6910b2fbd74eb237b73.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/a11562a90ba0612c68e427b64809ed4b50431764.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/a5180d2e8edfa2f50ba335a86f342b1b28525161.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/bob.info is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/d0e1f31bd583c4ef018dc24a9ca69cdb58a21e0b.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/db6dc8882333ce2b44c4b7ab57a40d0ec174cb34.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/val.info is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/writer.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/gentx/gentx-0af5fa98eea8f957a7ee0c30d6a1333e40382b65.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/gentx/gentx-bf961c82820f8b45262d42d29d5b5eed6aa82998.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/0d16cb2369afa892c981bda57d01773fa17e15eb.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/152460c2a0b87f0bdb86b26d43b6b6e4303ca2fd.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/4321b27aa17effe4688897cd2d7eca0866988f9b.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/57ff6c09751305d95096e7b69bf62784450b00b1.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/71888ecb7124b1258a0cd9492cf5ddbd5c875416.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/772e4eb79bdcd57db625471ae1deff5c0af164dd.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/7e2d7a6a9fba5f6d42a6ce681fddc97e9f36bd04.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/806b596dcce7d6ec57c299900b1a1aa75462f536.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/832cfcbe7f1b48c2cdfdf1cfa457315912258070.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/93258175732613f8e73b3f439638a038de8a64d7.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/ac147d880a5b72f0c84426791a34a84887d778b6.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/alice.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/bob.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/charlie.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/dave.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/e1dba28c2ce851da31adcfdcb212059d1d49ffab.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/erin.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/frank.info is excluded by !tests/testdata/**
warden/x/warden/types/v1beta3/events.pb.go is excluded by !**/*.pb.go
warden/x/warden/types/v1beta3/key.pb.go is excluded by !**/*.pb.go
warden/x/warden/types/v1beta3/space.pb.go is excluded by !**/*.pb.go
warden/x/warden/types/v1beta3/tx.pb.go is excluded by !**/*.pb.go

Files selected for processing (14)

CHANGELOG.md (1 hunks)
cmd/wardend/cmd/gen-spaces.go (1 hunks)
proto/warden/warden/v1beta3/events.proto (3 hunks)
proto/warden/warden/v1beta3/key.proto (2 hunks)
proto/warden/warden/v1beta3/space.proto (5 hunks)
proto/warden/warden/v1beta3/tx.proto (3 hunks)
tests/cases/keychain_writers.go (1 hunks)
warden/app/wasm-interop/custom_msg.go (3 hunks)
warden/x/warden/keeper/key_requests.go (2 hunks)
warden/x/warden/keeper/msg_server_fulfil_key_request.go (2 hunks)
warden/x/warden/keeper/msg_server_new_key_request.go (2 hunks)
warden/x/warden/keeper/msg_server_new_space.go (2 hunks)
warden/x/warden/keeper/msg_server_update_key.go (0 hunks)
warden/x/warden/keeper/msg_server_update_space.go (1 hunks)

Files not reviewed due to no reviewable changes (1)

warden/x/warden/keeper/msg_server_update_key.go

Additional context used

Path-based instructions (9)

warden/x/warden/keeper/msg_server_new_space.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

cmd/wardend/cmd/gen-spaces.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/x/warden/keeper/msg_server_new_key_request.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/x/warden/keeper/key_requests.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/x/warden/keeper/msg_server_fulfil_key_request.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/x/warden/keeper/msg_server_update_space.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/app/wasm-interop/custom_msg.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

tests/cases/keychain_writers.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (29)

warden/x/warden/keeper/msg_server_new_space.go (2)

14-18: LGTM!

The changes to the Space struct initialization are consistent with the PR objectives and provide more granular control over approval and rejection processes for the space's administrative and signing templates.

37-43: Looks good!

The updates to the EventCreateSpace event are consistent with the modifications made to the Space struct initialization and ensure that the emitted event reflects the current state of the Space object accurately.

cmd/wardend/cmd/gen-spaces.go (1)

34-41: LGTM!

The changes to the Space struct align with the PR objective of removing the template_id field and enhance the granularity of template management. The new fields for approval and rejection processes are correctly initialized to 0.

The code changes conform to the Uber Golang style guide.

warden/x/warden/keeper/msg_server_new_key_request.go (2)

48-49: LGTM!

The change from a single TemplateId to separate ApproveTemplateId and RejectTemplateId fields improves the flexibility of the key request process by allowing distinct templates for approval and rejection scenarios. This aligns well with the PR objective of removing the template_id field.

60-66: Looks good!

Updating the emitted event to include the ApproveTemplateId and RejectTemplateId fields instead of TemplateId ensures that the event accurately reflects the changes made to the KeyRequest struct. This maintains consistency and correctness in the event emission logic.

warden/x/warden/keeper/key_requests.go (1)

21-26: LGTM!

The changes to the Key struct initialization are consistent with the list of alterations provided in the AI summary. The addition of the ApproveTemplateId and RejectTemplateId fields enhances the functionality of the Key object by allowing it to store more information related to the approval and rejection templates. This potentially improves the handling of key requests by supporting more complex workflows regarding key approval and rejection processes.

warden/x/warden/keeper/msg_server_fulfil_key_request.go (1)

45-50: LGTM!

The addition of the ApproveTemplateId and RejectTemplateId fields to the EventNewKey event enhances the event's data structure by including additional identifiers related to key approval and rejection templates. This change may be relevant for tracking or processing key requests more effectively.

The code segment is correctly accessing these fields from the key object.

warden/x/warden/keeper/msg_server_update_space.go (1)

58-62: LGTM!

The event emission has been correctly updated to include the new fields ApproveAdminTemplateId, RejectAdminTemplateId, ApproveSignTemplateId, and RejectSignTemplateId from the space object. The changes are consistent with the AI-generated summary.

proto/warden/warden/v1beta3/space.proto (5)

18-18: LGTM!

The change in the nonce field index from 7 to 4 is a minor improvement to the field ordering and does not affect the functionality.

30-30: LGTM!

The update to the approve_admin_template_id field index from 8 to 5 is necessary to maintain the correct field ordering after the removal of the admin_template_id field. It does not affect the functionality.

42-42: LGTM!

The update to the reject_admin_template_id field index from 9 to 6 is necessary to maintain the correct field ordering after the removal of the admin_template_id field. It does not affect the functionality.

54-54: LGTM!

The update to the approve_sign_template_id field index from 10 to 7 is necessary to maintain the correct field ordering after the removal of the sign_template_id field. It does not affect the functionality.

66-66: LGTM!

The update to the reject_sign_template_id field index from 11 to 8 is necessary to maintain the correct field ordering after the removal of the sign_template_id field. It does not affect the functionality.

warden/app/wasm-interop/custom_msg.go (2)

24-29: LGTM!

The changes to the NewKeyRequest struct align with the PR objective of removing the template_id field. The introduction of ApproveTemplateId and RejectTemplateId fields enhances the functionality by allowing more nuanced control over the approval process. This change reflects a more complex interaction model and provides greater flexibility in template management.

60-65: Looks good!

The updates to the MsgNewKeyRequest message construction in the handleNewKeyRequest function are consistent with the changes made to the NewKeyRequest struct. The removal of the TemplateId field and the addition of ApproveTemplateId and RejectTemplateId fields ensure that the new fields are correctly propagated to the message. The changes are implemented accurately and maintain the integrity of the key request handling process.

proto/warden/warden/v1beta3/key.proto (2)

62-63: LGTM!

Adding the reject_template_id field enhances functionality by allowing a separate template for the rejection process. The field number and positioning are appropriate.

107-107: LGTM!

Renaming template_id to approve_template_id improves clarity and maintains consistency with the change in the KeyRequest message.

tests/cases/keychain_writers.go (2)

43-43: LGTM!

The removal of the --template-id parameter aligns with the PR objective and streamlines the key request creation process. The test logic remains valid.

48-48: Looks good!

The removal of the --template-id parameter is consistent with the previous change and the PR objective. The test remains effective in verifying the key request creation with a different fee amount.

proto/warden/warden/v1beta3/events.proto (5)

22-32: LGTM!

The changes to the EventCreateSpace message improve clarity by explicitly specifying the purpose of each template ID. The new field names are consistent with the PR objective of removing the generic template_id field and providing more specific names.

41-50: LGTM!

The changes to the EventUpdateSpace message improve clarity by explicitly specifying the purpose of each template ID. The removal of the generic admin_template_id and sign_template_id fields and the introduction of more specific approval and rejection template IDs are consistent with the PR objective.

88-98: LGTM!

The changes to the EventNewKeyRequest message improve clarity by explicitly specifying the purpose of each template ID. The replacement of the generic template_id field with approve_template_id and reject_template_id is consistent with the PR objective of providing more specific names.

115-119: LGTM!

The changes to the EventNewKey message improve clarity by explicitly specifying the purpose of each template ID. The replacement of the generic template_id field with approve_template_id and reject_template_id is consistent with the PR objective of providing more specific names.

Line range hint 1-1000: Verify the presence of reject_template_id in EventUpdateKey.

The change to approve_template_id in the EventUpdateKey message is consistent with the PR objective. However, the presence of reject_template_id without any annotation suggests that it may have been overlooked or is an inconsistency in the changes.

Please ensure that the presence of reject_template_id is intentional and consistent with the changes made to other messages. If it is not required, consider removing it for consistency.

proto/warden/warden/v1beta3/tx.proto (4)

92-96: LGTM!

The changes to MsgNewSpace introduce a more explicit approval/rejection mechanism for admin and sign templates, enhancing the clarity and functionality of the message structure. The field renumbering is consistent with the new approval/rejection fields.

147-151: LGTM!

The changes to MsgUpdateSpace are consistent with the updates made to MsgNewSpace. The removal of the old template ID fields and the addition of the new approval/rejection fields suggest a shift towards a more explicit approval/rejection mechanism for templates. The field renumbering is consistent with the new approval/rejection fields, enhancing the clarity and functionality of the message structure.

194-202: LGTM!

The changes to MsgNewKeyRequest introduce a more explicit approval/rejection mechanism for templates, consistent with the updates made to MsgNewSpace and MsgUpdateSpace. The field renumbering is consistent with the new approval/rejection fields and the max_keychain_fees field, enhancing the clarity and functionality of the message structure.

Line range hint 229-233: LGTM!

The changes to MsgUpdateKey are consistent with the updates made to other messages. The removal of the template_id field and the retention of the approval/rejection fields suggest a focus on managing key updates through explicit approval processes, enhancing the clarity and functionality of the message structure.

CHANGELOG.md (1)

66-66: LGTM!

The changelog entry accurately captures the removal of template ID fields from the Key and Space components, which aligns with the stated PR objective. The entry is free of any spelling or grammatical errors.

coderabbitai · 2024-09-13T13:48:04Z

proto/warden/warden/v1beta3/key.proto

+  // ID of the Template that the resulting Key will use with approve.
+  uint64 approve_template_id = 8;


Breaking change: Handle the field number update.

Renaming template_id to approve_template_id improves clarity. However, updating the field number from 8 to 9 is a breaking change. Ensure that all code referencing this field is updated to use the new field number.

coderabbitai · 2024-09-13T13:48:04Z

proto/warden/warden/v1beta3/key.proto


  // ID of the Template that will need to be satisfied for rejecting using this key to sign
  // data.
  // If this is not set, the key will use the reject signing Template of the Space.
-  uint64 reject_template_id = 8;
+  uint64 reject_template_id = 7;


Breaking change: Handle the field number update.

Reordering the reject_template_id field to align with the KeyRequest message is a good change. However, updating the field number from 7 to 6 is a breaking change. Ensure that all code referencing this field is updated to use the new field number.

artur-abliazimov · 2024-09-13T13:52:50Z

Let's also regenerate types in wardenjs.

Let's also increment wardenjs version in the package.json.

rm template_id fields

a896e59

github-actions bot added protocol protobuf x-warden labels Sep 13, 2024

mn13 added 3 commits September 13, 2024 16:40

fix

ce3946d

update changelog

655a06a

fix tests

ba58c97

mn13 marked this pull request as ready for review September 13, 2024 13:40

update wardenjs

7b11ad7

coderabbitai bot reviewed Sep 13, 2024

View reviewed changes

github-actions bot added spaceward wardenjs labels Sep 13, 2024

bump wardenjs version

e9186d6

artur-abliazimov approved these changes Sep 13, 2024

View reviewed changes

mn13 merged commit 72b95f3 into main Sep 13, 2024
18 of 19 checks passed

mn13 deleted the fix/cleanup-template-id-fields branch September 13, 2024 14:15

coderabbitai bot mentioned this pull request Sep 25, 2024

822 Act & Warden Precompiles #889

Closed

This was referenced Oct 3, 2024

update evmos to v20 #919

Merged

Add AutoEstimateGas and GasAdjustmentFactor parameters to estimate gas automatically before broadcasting the tx #847

Open

coderabbitai bot mentioned this pull request Oct 17, 2024

Fix/new key event #940

Merged

This was referenced Nov 13, 2024

1011 add a type field for signature request #1042

Merged

986 Contract as approver #1047

Merged

Improve precompiles typings by utilizing enums consistently #1077

Merged

992 relayer #1043

Closed

992 Transactions Relayer #1084

Merged

This was referenced Nov 22, 2024

1071 add aws kms to scheduler #1085

Merged

#683 keychain sdk configure multiple nodes endpoints #810

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rm template_id fields #840

rm template_id fields #840

mn13 commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

vercel bot commented Sep 13, 2024 •

edited

Loading

artur-abliazimov commented Sep 13, 2024

coderabbitai bot left a comment

coderabbitai bot Sep 13, 2024

coderabbitai bot Sep 13, 2024

artur-abliazimov commented Sep 13, 2024

		// ID of the Template that the resulting Key will use with approve.
		uint64 approve_template_id = 8;

rm template_id fields #840

rm template_id fields #840

Conversation

mn13 commented Sep 13, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 13, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

vercel bot commented Sep 13, 2024 • edited Loading

artur-abliazimov commented Sep 13, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Sep 13, 2024

Choose a reason for hiding this comment

coderabbitai bot Sep 13, 2024

Choose a reason for hiding this comment

artur-abliazimov commented Sep 13, 2024

mn13 commented Sep 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 13, 2024 •

edited

Loading

vercel bot commented Sep 13, 2024 •

edited

Loading