Feature/evm module #447

mn13 · 2024-06-25T15:08:01Z

Summary by CodeRabbit

New Features
- Integration of Ethereum Virtual Machine (EVM) capabilities into the application.
- Introduction of a new currency denomination, "award," replacing "uward."
- Enhanced configuration options for EVM and Fee Market settings.
- Improved transaction handling and key management features.
Bug Fixes
- Resolved dependency issues to improve compatibility within the Evmos ecosystem.
Documentation
- Updated CHANGELOG.md to reflect recent changes and enhancements.
- Adjusted key derivation path in documentation to align with Ethereum standards.
Chores
- Dependency updates and removals for improved performance and compatibility.

coderabbitai · 2024-06-25T15:08:54Z

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the integration of the Ethereum Virtual Machine (EVM) within the Evmos ecosystem, introducing new features and modifying existing functionalities. Key updates include a shift in currency denomination from "uward" to "award," expanded command handling, and structural adjustments to support Ethereum transactions and fee management. These changes collectively aim to improve compatibility and the overall functionality of the application in blockchain interactions.

Changes

Files	Change Summary
`CHANGELOG.md`	Introduction of new features for EVM integration, including a new award denomination and updates to transaction handling with ethsecp256k1 signatures.
`tests/cases/keychain_writers.go`	Modification of string literals in test cases, changing "uward" to "award" in the `--max-keychain-fees` parameter across multiple instances, reflecting updates in fee terminology.
`go.mod`	Updates to module dependencies, including the addition of Evmos-related libraries and updates to existing dependencies for better functionality and performance.
`warden/app/*.go`	Enhancements for EVM support, including new keepers, updated ante handlers, and integrated fee market functionalities, expanding the application's transaction handling capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CommandLine
    participant App
    participant EVMHandler
    participant FeeMarketHandler

    User->>CommandLine: Initiate a transaction
    CommandLine->>App: Process transaction command
    App->>EVMHandler: Check EVM-related options
    EVMHandler-->>App: Return EVM options
    App->>FeeMarketHandler: Calculate fees based on new denomination
    FeeMarketHandler-->>App: Return calculated fees
    App->>CommandLine: Confirm transaction details
    CommandLine->>User: Display transaction confirmation

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mn13 · 2024-06-25T15:09:37Z

Hey @MalteHerrmann, here is a draft PR to track our integration progress

vercel · 2024-07-08T16:22:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
warden-help-center	⬜️ Ignored (Inspect)	Visit Preview		Sep 4, 2024 8:12am

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (3)

localnet.just (2)
23-23: Inconsistent usage of default denomination across the codebase

The codebase contains both the old denomination uward and the new denomination award. To ensure consistency and avoid potential issues, all occurrences of uward should be updated to award.

Files with uward:

spaceward/src/pages/Staking.tsx

spaceward/src/hooks/useClient.ts

spaceward/src/features/staking/util.ts

spaceward/src/features/staking/hooks.ts

spaceward/src/features/staking/StakeModal.tsx

spaceward/src/features/spaces/NoSpaces.tsx

spaceward/src/features/governance/hooks.ts

spaceward/src/features/actions/hooks.ts

spaceward/src/config/chains.ts

spaceward/src/components/ConnectWallet.tsx

warden/x/warden/migrations/v3/store.go

warden/x/act/client/actions.go

docker-compose.yml

cmd/faucet/pkg/config/config.go

cmd/faucet/faucet.go

docs/developer-docs/docs/build-an-app/test/run-a-keychain-from-cli.md

docs/developer-docs/docs/build-an-app/test/run-a-local-chain.md

docs/developer-docs/docs/operate-a-node/create-a-validator.md

docs/developer-docs/docs/operate-a-node/buenavista-testnet/join-buenavista.md

docs/developer-docs/docs/build-a-keychain/quick-start.md

Files with award:

localnet.just

tests/justfile

tests/testdata/snapshot-base/config/genesis.json

tests/testdata/snapshot-many-users/config/genesis.json

tests/testdata/snapshot-keychain/config/genesis.json

tests/cases/keychain_writers.go

go-client/tx_raw_client.go

cmd/wardenkms/wardenkms.go

cmd/faucet-v2/main.go

Please update all instances of uward to award to ensure uniformity.

Analysis chain

Verify the usage of the new default denomination across the codebase.

Ensure that the new default denomination award is consistently used across all relevant commands and configurations.

Run the following script to verify the default denomination usage:
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the usage of the new default denomination across the codebase.

# Test: Search for the old default denomination. Expect: No occurrences of the old default denomination.
rg --type justfile $'uward'

# Test: Search for the new default denomination. Expect: Occurrences of the new default denomination in relevant commands and configurations.
rg --type justfile $'award'
Length of output: 119

Script:
#!/bin/bash
# Description: Verify the usage of the new default denomination across the codebase.

# Test: Search for the old default denomination. Expect: No occurrences of the old default denomination.
rg 'uward'

# Test: Search for the new default denomination. Expect: Occurrences of the new default denomination in relevant commands and configurations.
rg 'award'
Length of output: 15269
1-1: Update all occurrences of the old chain_id to the new chain_id.

The old chain_id "warden" is still present in multiple files across the codebase. Ensure that all references to the old chain_id are updated to "warden_1337-1" to maintain consistency and avoid potential issues.

Files with old chain_id references include:

wardend.just

warden/x/warden/types/v1beta2/query.pb.gw.go

warden/x/warden/types/v1beta3/query.pb.gw.go

tests/slinky/slinky_test.go

docs/developer-docs/docs/build-a-keychain/quick-start.md

spaceward/src/env.ts

cmd/faucet/faucet.go

And others as listed in the output.

Analysis chain

Verify the usage of the new chain_id across the codebase.

Ensure that the new chain_id "warden_1337-1" is consistently used across all relevant commands and configurations.

Run the following script to verify the chain_id usage:
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the usage of the new `chain_id` across the codebase.

# Test: Search for the old `chain_id`. Expect: No occurrences of the old `chain_id`.
rg --type justfile $'"warden"'

# Test: Search for the new `chain_id`. Expect: Occurrences of the new `chain_id` in relevant commands and configurations.
rg --type justfile $'"warden_1337-1"'
Length of output: 136

Script:
#!/bin/bash
# Description: Verify the usage of the new `chain_id` across the codebase without specifying a file type.

# Test: Search for the old `chain_id`. Expect: No occurrences of the old `chain_id`.
rg '"warden"'

# Test: Search for the new `chain_id`. Expect: Occurrences of the new `chain_id` in relevant commands and configurations.
rg '"warden_1337-1"'
Length of output: 11752
warden/app/legacy.go (1)

286-290: LGTM!

The addition of Ethereum precompiles is correctly implemented using the WithPrecompiles method. The code comment provides clarity on the flexibility to add more precompiles if needed.

Consider adding a TODO comment to track the potential addition of custom precompiles in the future, if required by the project's roadmap.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf6d6e6 and 6671868.

Files ignored due to path filters (55)

go.sum is excluded by !**/*.sum
tests/testdata/snapshot-base/config/app.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/client.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/config.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/gentx/gentx-ad8e6990a2d43f03134cf9ccef09a682ccb7848e.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/gentx/gentx-edea41fe7a5926a8ba78dc347bddd1cc79f40c70.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/1e6d41adae26827525b62664ebe2e5b91e0288fc.address is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/21575f14f36f239f4f8f2b0c6de2f20abbbc35ef.address is excluded by !tests/testdata/**
tests/testdata/snapshot-base/keyring-test/alice.info is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/app.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/client.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/config.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/gentx/gentx-3086b01687ba4f1cb68973bab49dc5c04355b751.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/gentx/gentx-ddf8fa75c9baf73c00db1b864d6e5fd42e09b36d.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/0584e8dd25ffca6d116c72d015e9f5dab7e76f94.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/3b8b0b54cb61e9ae96f832a812f2190600fad708.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/48a7814de526a57c9f78e7215ef52d2b0a118e43.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/4d8f6c4d5292348f51b833357c6544d65ae9a6f4.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/97628288901c43e05c5ff1b01751397434fe994b.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/9f2129793d7187ea00f49542aa3e487cd48ab2f7.address is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/bob.info is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/val.info is excluded by !tests/testdata/**
tests/testdata/snapshot-keychain/keyring-test/writer.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/app.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/client.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/config.toml.tmpl is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/genesis.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/gentx/gentx-8135796bf9bf192aa19db49fdb8f354bf570c985.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/gentx/gentx-ac908e15484dc79c515ab0f93e01e40cfeb06449.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/node_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/config/priv_validator_key.json is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/05e186cab7ddae4633e3fe2c947039de6ae635bf.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/101e05d7b782e9dd64b7bee7c6bb248eafacf450.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/139d48da1f68b5c8964e9c1e775578a05df2a9c6.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/2d114cd6426dd05095dfaa50a301e3f0595ad380.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/2f0be4bcaa3822fd207bb07be752e13636b4e954.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/2fd1470a60bdf72875a7f549fe653d7b9c7099cf.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/4284bac9c698aac6cffade5b919fe0d0c7f1bcd8.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/6f639d8ac4249286acd5aa5cef894b1d8374468d.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/a9bb91295de9ddfb784d1859ecf5f22dd48537a5.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/alice.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/bob.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/c6d9b47124c5dddfb36bc2fd571c0418633c10d0.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/ced172667cdb33ce4658a091cf4c8a15b1256280.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/charlie.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/d99e5c8fa41c8df7764a5b12028c0ef5cc4206c2.address is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/dave.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/erin.info is excluded by !tests/testdata/**
tests/testdata/snapshot-many-users/keyring-test/frank.info is excluded by !tests/testdata/**

Files selected for processing (25)

CHANGELOG.md (1 hunks)
cmd/faucet-v2/main.go (1 hunks)
cmd/wardend/cmd/commands.go (4 hunks)
cmd/wardend/cmd/config.go (3 hunks)
cmd/wardend/cmd/gen-accounts.go (1 hunks)
cmd/wardend/cmd/root.go (3 hunks)
cmd/wardenkms/wardenkms.go (2 hunks)
docs/developer-docs/.spelling (1 hunks)
docs/developer-docs/docs/build-a-keychain/quick-start.md (1 hunks)
docs/developer-docs/docs/build-an-app/test/run-a-keychain-from-cli.md (1 hunks)
go-client/tx_raw_client.go (1 hunks)
go.mod (13 hunks)
keychain-sdk/config.go (1 hunks)
keychain-sdk/example_keychain_test.go (1 hunks)
localnet.just (2 hunks)
tests/cases/keychain_writers.go (3 hunks)
tests/framework/exec/warden_cli.go (1 hunks)
tests/justfile (4 hunks)
tests/slinky/slinky_test.go (1 hunks)
warden/app/ante.go (4 hunks)
warden/app/app.go (9 hunks)
warden/app/app_config.go (8 hunks)
warden/app/legacy.go (7 hunks)
warden/app/oracle.go (1 hunks)
wardend.just (1 hunks)

Files skipped from review due to trivial changes (4)

keychain-sdk/config.go
tests/cases/keychain_writers.go
tests/slinky/slinky_test.go
warden/app/oracle.go

Files skipped from review as they are similar to previous changes (12)

CHANGELOG.md
cmd/faucet-v2/main.go
cmd/wardend/cmd/commands.go
cmd/wardend/cmd/gen-accounts.go
cmd/wardend/cmd/root.go
docs/developer-docs/.spelling
docs/developer-docs/docs/build-a-keychain/quick-start.md
docs/developer-docs/docs/build-an-app/test/run-a-keychain-from-cli.md
keychain-sdk/example_keychain_test.go
warden/app/app.go
warden/app/app_config.go
wardend.just

Additional context used

Path-based instructions (7)

tests/framework/exec/warden_cli.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

cmd/wardenkms/wardenkms.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

cmd/wardend/cmd/config.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

go-client/tx_raw_client.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

warden/app/ante.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

tests/justfile (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

warden/app/legacy.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (33)

tests/framework/exec/warden_cli.go (1)

30-30: LGTM!

The change to the TxAppend string formatting, updating the chain ID to warden_1337-1, is consistent with the AI-generated summary and does not introduce any issues or deviations from the Uber Go Style Guide. The modification reflects a shift in the network configuration or environment, tailoring the function to interact with a different blockchain network or a specific test environment.

localnet.just (5)

26-26: LGTM!

The code changes are approved.

33-33: LGTM!

The code changes are approved.

34-34: LGTM!

The code changes are approved.

37-37: LGTM!

The code changes are approved.

39-39: LGTM!

The code changes are approved.

cmd/wardenkms/wardenkms.go (3)

23-23: Verify the change to the default chain identifier.

The default value for the ChainID field has been updated from "warden" to "warden_1337-1". Please ensure that this change is intentional and aligns with the project's requirements.

26-26: Verify the change to the default derivation path.

The default value for the DerivationPath field has been updated from "m/44'/118'/0'/0/0" to "m/44'/60'/0'/0/0". Please ensure that this change is intentional and has been thoroughly tested to maintain compatibility with the desired wallet functionality and key management.

72-72: Verify the change to the transaction fees configuration.

The coin denomination used for transaction fees has been updated from "uward" to "award" within the TxFees field. Please ensure that this change is intentional and aligns with the project's requirements.

Additionally, it's important to ensure that this change is consistently applied throughout the codebase. Please verify that any related documentation, configurations, or other parts of the system have been updated to reflect the new denomination.

cmd/wardend/cmd/config.go (5)

9-9: LGTM!

The code changes are approved.

32-36: LGTM!

The code changes are approved.

64-85: LGTM!

The code changes are approved.

89-94: LGTM!

The code changes are approved.

97-97: LGTM!

The code changes are approved.

go-client/tx_raw_client.go (2)

26-26: Verify the gas limit value and its implications.

The DefaultGasLimit has been increased significantly from 300,000 to 300,000,000,000,000,000. While increasing the gas limit allows more complex transactions, setting an extremely high value may lead to unexpected behavior or security vulnerabilities if not properly validated.

Please ensure that the new gas limit value is intentional and has been thoroughly tested. Consider the following:

Confirm that the increased gas limit aligns with the expected transaction complexity and resource consumption.

Verify that the gas limit is properly validated and constrained within acceptable bounds to prevent potential abuse or denial-of-service attacks.

Assess the impact of the increased gas limit on the overall system performance, including block processing times and resource utilization.

Provide additional context or justification for the chosen gas limit value to ensure its appropriateness and security.

27-27: Clarify the reasoning behind the fee and currency changes.

The DefaultFees have been modified from 1,000 units of "uward" to 1,000,000,000,000,000 units of "award". This change not only increases the fee value significantly but also introduces a new currency denomination.

Please provide clarification on the following points:

What is the rationale behind changing the currency denomination from "uward" to "award"? Is this change reflected consistently throughout the codebase and documentation?

The new fee value (1,000,000,000,000,000) is significantly higher compared to the previous value (1,000). Has this increase been carefully considered in terms of its impact on user adoption, transaction costs, and overall system economics? Please justify the chosen fee value.

Have the implications of these changes on the existing user base, wallets, and external systems been thoroughly assessed? Is there a migration plan in place to handle the transition smoothly?

Addressing these points will help ensure a clear understanding of the motivations behind the changes and their potential impact on the system and its users.

warden/app/ante.go (5)

Line range hint 30-49: LGTM!

The changes to the HandlerOptions struct are approved. The new fields are necessary to support the integration of EVM functionalities into the ante handler. The fields are of appropriate types and follow the naming conventions.

Line range hint 51-78: LGTM!

The newCosmosAnteHandler function is well-structured and follows the necessary steps for handling Cosmos transactions. The ante decorators are chained in a logical order. The rejection of MsgEthereumTx messages and the disabling of certain message types for authz.MsgExec are appropriate.

80-92: LGTM!

The newMonoEVMAnteHandler function is concise and uses the MonoDecorator to handle EVM transactions. The necessary keepers and options are passed to the decorator.

94-133: LGTM!

The ValidateAnteHandlerOptions function is a good addition to ensure that all the necessary components are present before creating the ante handler. It helps catch missing dependencies early in the process.

135-171: LGTM!

The refactored NewAnteHandler function provides a clean way to differentiate between Cosmos and EVM transactions. The use of extension options to identify EVM transactions is a good approach. The error handling for unsupported extension options and invalid transaction types is appropriate.

tests/justfile (4)

45-45: LGTM!

The changes to the wardend init command, updating the chain ID to warden_1337-1 and default denomination to award, are consistent with the PR objectives.

50-51: LGTM!

The changes to the wardend genesis add-genesis-account and wardend genesis gentx commands, updating the default denomination to award, are consistent with the PR objectives.

55-55: LGTM!

The change to the wardend config set app minimum-gas-prices command, updating the default denomination to award, is consistent with the PR objectives.

103-108: Also applies to: 112-112, 153-154, 164-168, 172-172
go.mod (4)
6-11: The existing comments from previous reviews are still valid for this code segment. Skipping generating a similar comment.

22-22: Approve version update.

The version update of cosmossdk.io/core module from v0.11.1 to v0.12.0 is approved. It indicates enhancements or bug fixes in the core functionalities of the module.

32-32: Approve version update.

The version update of cosmossdk.io/x/tx module from v0.13.3 to v0.13.4 is approved. It is a minor change and should not have any breaking changes.

48-49: Verify the usage of the new module in the codebase.

The addition of the new module dependency github.com/evmos/evmos/v18 at version v18.0.0-20240719123340-11b5d80cf7bb is related to the Evmos integration. Please verify that the module is being used correctly in the codebase.

Run the following script to verify the module usage:

Verification successful

The new module github.com/evmos/evmos/v18 is being used correctly in the codebase.

The module is imported and utilized across various files, indicating a comprehensive integration with Evmos functionalities. The usage spans different components such as ante handlers, keyring, and vesting, confirming its correct implementation.

Files with imports: warden/app/ante.go, warden/app/legacy.go, warden/app/app_config.go, warden/app/app.go, cmd/wardend/cmd/root.go, cmd/wardend/cmd/gen-accounts.go, cmd/wardend/cmd/commands.go, cmd/wardend/cmd/config.go
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the usage of the new module `github.com/evmos/evmos/v18` in the codebase.

# Test: Search for the module import and usage. Expect: The module is imported and used correctly.
rg --type go -A 5 $'github.com/evmos/evmos/v18'
Length of output: 4828
warden/app/legacy.go (4)

46-46: LGTM!

The new import statements for EVM-related packages are correctly added and follow the proper formatting.

Also applies to: 61-68

88-93: LGTM!

The changes in the registerLegacyModules function correctly set up the necessary infrastructure for the EVM and fee market integration. The store keys and parameter subspaces are properly initialized.

Also applies to: 105-107

263-269: LGTM!

The creation of the FeeMarketKeeper and EvmKeeper is properly implemented. The keepers are initialized with the required dependencies and configurations. The tracer setup for the EvmKeeper allows for flexible tracing options.

Also applies to: 271-284

345-347: LGTM!

The registration of the EVM and fee market modules is correctly implemented. The modules are properly added to the application's module manager, ensuring their proper functioning within the application.

Pitasi

LGTM!

github-actions bot added the protocol label Jun 25, 2024

mn13 assigned mn13 and unassigned mn13 Jul 3, 2024

vercel bot had a problem deploying to Preview – warden-docs July 8, 2024 16:22 Failure

vercel bot had a problem deploying to Preview – warden-help-center July 8, 2024 16:22 Failure

vercel bot had a problem deploying to Preview – warden-docs July 8, 2024 16:25 Failure

vercel bot had a problem deploying to Preview – warden-help-center July 8, 2024 16:26 Failure

vercel bot had a problem deploying to Preview – warden-docs July 10, 2024 14:25 Failure

github-actions bot added docs go-client wardenkms labels Jul 10, 2024

vercel bot had a problem deploying to Preview – warden-help-center July 10, 2024 14:25 Failure

vercel bot had a problem deploying to Preview – warden-docs July 10, 2024 14:25 Failure

vercel bot had a problem deploying to Preview – warden-help-center July 11, 2024 14:24 Failure

vercel bot had a problem deploying to Preview – warden-docs July 11, 2024 14:24 Failure

vercel bot had a problem deploying to Preview – warden-help-center July 17, 2024 12:34 Failure

vercel bot had a problem deploying to Preview – warden-docs July 17, 2024 12:34 Failure

vercel bot had a problem deploying to Preview – warden-help-center August 5, 2024 11:07 Failure

vercel bot had a problem deploying to Preview – warden-docs August 5, 2024 11:07 Failure

vercel bot had a problem deploying to Preview – warden-help-center August 13, 2024 14:44 Failure

vercel bot had a problem deploying to Preview – warden-docs August 13, 2024 14:44 Failure

mn13 force-pushed the feature/evm-module branch from f97994f to e973724 Compare August 14, 2024 13:21

github-actions bot removed the docs label Aug 14, 2024

mn13 force-pushed the feature/evm-module branch from e973724 to 522b147 Compare August 14, 2024 13:24

mn13 marked this pull request as ready for review August 15, 2024 09:03

mn13 force-pushed the feature/evm-module branch from dca9dfa to c5433c1 Compare August 15, 2024 09:03

mn13 added 18 commits September 3, 2024 10:30

use award instead of uward

71f8ad4

add setting evmOS params on migration

078104b

extend customAppConfig with emv configs

c3bb7da

rm unused ProvideInterfaceRegistryNoValidation

f40b508

use evmOS's cosmos-sdk

cd71f6f

fix eth sign types issues

238483a

rm print

e4c7b16

bump cosmos-sdk version

91d9b2d

edit changelog

e1ebdbc

regenerate tests snapshots

0a4b030

update changelog

f726b23

bump sdk to v0.50.9

a27a186

rebase fixes

0a0d485

go mod tidy

6537943

rm evm part from upgrade

379903b

review updates

b4ac60b

go mod tidy

e4de871

fix denom in tests

6671868

mn13 force-pushed the feature/evm-module branch from cf6d6e6 to 6671868 Compare September 3, 2024 07:30

coderabbitai bot reviewed Sep 3, 2024

View reviewed changes

Pitasi previously approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'main' into feature/evm-module

388e3ac

mn13 dismissed Pitasi’s stale review via 388e3ac September 4, 2024 08:10

vercel bot deployed to Preview – warden-docs September 4, 2024 08:12 View deployment

Pitasi approved these changes Sep 4, 2024

View reviewed changes

mn13 merged commit e4a48af into main Sep 4, 2024
22 of 23 checks passed

mn13 deleted the feature/evm-module branch September 4, 2024 08:16

This was referenced Nov 5, 2024

Docs chiado changes #1030

Merged

992 relayer #1043

Closed

coderabbitai bot mentioned this pull request Nov 26, 2024

Docs links modules #1104

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/evm module #447

Feature/evm module #447

mn13 commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

mn13 commented Jun 25, 2024

vercel bot commented Jul 8, 2024 •

edited

Loading

coderabbitai bot left a comment

Pitasi left a comment

Feature/evm module #447

Feature/evm module #447

Conversation

mn13 commented Jun 25, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jun 25, 2024 • edited Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

mn13 commented Jun 25, 2024

vercel bot commented Jul 8, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

Pitasi left a comment

Choose a reason for hiding this comment

mn13 commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

vercel bot commented Jul 8, 2024 •

edited

Loading