fix(x/intent): QueryActionsByAddress returning one Action multiple times

[Pitasi]

The problem here was that we were storing a list of pointers, but actually a list of the same pointer N times. The simple fix is to avoid pointer at all by marking the field as non-nullable in protobufs.

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue causing repeated actions in query results, ensuring accurate and unique action listings.
• Documentation
  • Updated API specifications to reflect non-nullable action fields in responses.
• Refactor
  • Improved data handling in action queries to enhance performance and reliability.

[coderabbitai]

Walkthrough

The recent updates aim to improve the functionality and reliability of the QueryActionsByAddress function. A critical bug fix prevents the reuse of a pointer in a loop, ensuring accurate query results. Changes also include adjusting the response structure in the protobuf definition to handle non-nullable action fields and optimizing data handling in Go by transitioning from pointer-based to direct struct appending for improved memory management.

Changes

File Path	Change Summary
CHANGELOG.md	Implemented a bug fix in QueryActionsByAddress to prevent pointer reuse, ensuring correct query results.
proto/warden/intent/query.proto	Specified nullable: false for repeated Action actions in QueryActionsByAddressResponse.
warden/x/intent/keeper/query_actions_by_address.go	Updated result variable type to slice of types.Action from pointers, enhancing data handling.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Actionable comments outside the diff hunks (2)

CHANGELOG.md (2)

Line range hint 57-57: Adjust the indentation for the unordered list to match the expected 2 spaces.

-    * Derive Osmosis addresses from ECDSA_SECP256K1 keys
+  * Derive Osmosis addresses from ECDSA_SECP256K1 keys

---

Line range hint 41-41: Remove the extra blank line to maintain a single blank line between sections.

-