Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on invalid UTF-8 in /p/ #1

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

NoraCodes
Copy link
Contributor

Previously, uploading a paste with invalid UTF-8 and then viewing it with the pretty URL would cause a panic. With this change, it simply redirects to the raw URL.

@wantguns
Copy link
Owner

wantguns commented Feb 2, 2022

Thanks for the input !
Could you please ammend the latest commit after you've run cargo fmt on the project ?
I should have added a PR template :')

@NoraCodes
Copy link
Contributor Author

Yep, will do - sorry about that 😅

@NoraCodes NoraCodes force-pushed the nora/redirect_on_invalid_utf8 branch 2 times, most recently from 7cf45f1 to ec3dfdc Compare February 2, 2022 15:45
@wantguns
Copy link
Owner

wantguns commented Feb 2, 2022

Now Clippy is complaining :')

After that, there will be another check in the pipeline which just checks whether the project can be compiled, and cross-compiled w/o any errors.

Please take a look at this, I am gonna make a PR template --
https://github.com/WantGuns/bin/blob/ea144a1024e6e28516a6d0a02bc7dba1e8110e25/.github/workflows/buildci.yml#L12-L16

Previously, uploading a paste with invalid UTF-8 and then viewing it
with the pretty URL would cause a panic.
With this change, it simply redirects to the raw URL.
@NoraCodes NoraCodes force-pushed the nora/redirect_on_invalid_utf8 branch from ec3dfdc to 5aafe25 Compare February 2, 2022 18:52
@wantguns wantguns merged commit 022f320 into wantguns:master Feb 2, 2022
@wantguns
Copy link
Owner

wantguns commented Feb 2, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants