test(table): add table utils has-common test

[cycleccc]

Changes Overview

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

• I have created a changeset for this PR if necessary.
• My changes do not break the library.
• I have added tests where applicable.
• I have followed the project guidelines.
• I have fixed any lint issues.

Related Issues

Summary by CodeRabbit

• Tests
  • Added new test file to validate the hasCommon utility function
  • Enhanced TypeScript configuration to support Vitest testing framework
  • Expanded test file inclusion in compilation process

[coderabbitai]

Walkthrough

A new test file has-common.test.ts has been added to the packages/table-module/__tests__/utils/ directory to validate the hasCommon utility function. The test suite uses the @wangeditor-next/core and slate libraries to test two scenarios: verifying common table ancestors and ensuring correct handling of paths without shared ancestors. Simultaneously, the tsconfig.json was updated to include Vitest global types and expand test file compilation.

Changes

File	Change Summary
packages/table-module/__tests__/utils/has-common.test.ts	New test file added to validate hasCommon utility function with two test cases
tsconfig.json	Added "vitest/globals" to compiler types and expanded test file inclusion pattern

Poem

🐰 In the realm of code, a test takes flight,
Checking paths with algorithmic might
Tables aligned, ancestors clear
Vitest types now drawing near
A rabbit's test, precise and bright! 🧪

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

packages/table-module/__tests__/utils/has-common.test.ts (4)

21-24: Consider improving test isolation.

Creating and setting up the editor in the describe block could lead to state sharing between tests. Consider moving the editor creation and setup into beforeEach to ensure each test starts with a fresh editor state.

 describe('hasCommon', () => {
-  const editor = createEditor()
-  setEditorSelection(editor)
+  let editor: core.IDomEditor
+
+  beforeEach(() => {
+    editor = createEditor()
+    setEditorSelection(editor)
+  })

---

87-87: Translate comment to English for consistency.

The Chinese comment // 插入 divider should be in English.

- editor.insertNode(elem) // 插入 divider
+ editor.insertNode(elem) // Insert table element

---

26-91: Consider adding more assertions and edge cases.

While the test correctly verifies the basic functionality, consider:

1. Testing with different depths of common ancestors
2. Adding assertions to verify the table structure was inserted correctly
3. Testing with invalid or malformed paths

---

21-100: Enhance test coverage with additional scenarios.

Consider adding test cases for:

1. Null/undefined paths
2. Empty path arrays
3. Invalid node types
4. Deeply nested structures
5. Multiple paths with mixed common/non-common ancestors

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93752fe and 8f7c4ce.

📒 Files selected for processing (2)

• packages/table-module/__tests__/utils/has-common.test.ts (1 hunks)
• tsconfig.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test
• GitHub Check: test-e2e

🔇 Additional comments (3)

packages/table-module/__tests__/utils/has-common.test.ts (2)

5-19: Well-structured test setup!

Good job on the imports organization and the typed helper function implementation.

---

93-99: Verify type parameter consistency.

The first test uses 'tr' as the type parameter for hasCommon, while this test uses 'table'. Ensure this difference is intentional and document the reason if it is.

tsconfig.json (1)

30-32: LGTM! Configuration changes look good.

The addition of Vitest globals and test file patterns is appropriate for supporting the new test implementation.

Also applies to: 41-42