Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code select lang): add default select lang #157

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

wjw020206
Copy link
Collaborator

@wjw020206 wjw020206 commented Sep 3, 2024

#155

Summary by CodeRabbit

  • New Features

    • Introduced a default programming language selection in the language menu.
    • Enhanced the language options to indicate which one is selected by default.
  • Bug Fixes

    • Improved the consistency of the return value when no valid language selection is made.

Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Walkthrough

The changes to the SelectLangMenu class introduce a new property, defaultCodeLang, to store the default programming language. The getOptions method now includes a selected property to mark the chosen language, updating defaultCodeLang accordingly. Additionally, the getValue method has been modified to return defaultCodeLang instead of an empty string when no valid selection is found, enhancing the method's robustness and consistency.

Changes

Files Change Summary
packages/code-highlight/src/module/menu/SelectLangMenu.ts Added defaultCodeLang property to store the default language. Updated getOptions and getValue methods for improved selection handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SelectLangMenu
    participant LanguageOptions

    User->>SelectLangMenu: Request language options
    SelectLangMenu->>LanguageOptions: Fetch available languages
    LanguageOptions-->>SelectLangMenu: Return languages
    SelectLangMenu->>User: Display languages with selection
    User->>SelectLangMenu: Select language
    SelectLangMenu->>SelectLangMenu: Update defaultCodeLang
    SelectLangMenu->>User: Confirm selection
Loading

Poem

🐰 In the meadow, languages bloom,
A default choice dispels the gloom.
With a hop and a skip, we select with glee,
Code flows like rivers, wild and free!
Hooray for the change, let’s celebrate,
A menu so bright, it’s simply great! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wjw020206 wjw020206 requested a review from cycleccc September 3, 2024 15:03
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef8bebf and 482f645.

Files selected for processing (1)
  • packages/code-highlight/src/module/menu/SelectLangMenu.ts (4 hunks)
Additional comments not posted (4)
packages/code-highlight/src/module/menu/SelectLangMenu.ts (4)

17-17: LGTM!

The code changes are approved.


29-36: LGTM!

The code changes are approved.


64-65: LGTM!

The code changes are approved.


74-74: LGTM!

The code changes are approved.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 482f645 and f08c63c.

Files selected for processing (1)
  • packages/code-highlight/src/module/menu/SelectLangMenu.ts (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/code-highlight/src/module/menu/SelectLangMenu.ts

@cycleccc cycleccc merged commit 2e91f8e into master Sep 4, 2024
@wjw020206 wjw020206 deleted the feature/add-default-select-lang branch September 4, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants