fix sofastack#1380

wangchengming666 · Mar 1, 2024 · c5b0eac · c5b0eac
1 parent cf37047
commit c5b0eac
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java b/registry/registry-nacos/src/main/java/com/alipay/sofa/rpc/registry/nacos/NacosRegistry.java
@@ -149,21 +149,17 @@ public synchronized void init() {
             nacosConfig.putAll(parameters);
         }
 
+        lock.lock();
         try {
             if (providerObserver == null) {
-                lock.lock();
-                try {
-                    if (providerObserver == null) {
-                        providerObserver = new NacosRegistryProviderObserver();
-                    }
-                } finally {
-                    lock.unlock();
-                }
+                providerObserver = new NacosRegistryProviderObserver();
             }
 
             namingService = NamingFactory.createNamingService(nacosConfig);
         } catch (NacosException e) {
             throw new SofaRpcRuntimeException(LogCodes.getLog(LogCodes.ERROR_INIT_NACOS_NAMING_SERVICE, address), e);
+        }finally {
+            lock.unlock();
         }
     }