Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added service account name in stackdriver conf #136

Merged
merged 19 commits into from
Jun 18, 2024

Conversation

amanpruthi
Copy link
Collaborator

stackdriver = {
install = true
stackdriver = {
projectId = data.google_client_config.current.project
serviceAccountName = var.service_account_name
}
serviceAccount = { annotations = { "iam.gke.io/gcp-service-account" = module.service_accounts.monitoring_role } }
}

@amanpruthi amanpruthi requested a review from a team as a code owner June 10, 2024 07:36
@amanpruthi amanpruthi force-pushed the aman/otel-stackdriver-support branch from 1edd6f8 to 74dbae7 Compare June 13, 2024 07:19
@amanpruthi amanpruthi force-pushed the aman/otel-stackdriver-support branch from 10c15db to fafe855 Compare June 13, 2024 07:36
@adityachoudhari26 adityachoudhari26 merged commit 87aa2b9 into main Jun 18, 2024
6 checks passed
@adityachoudhari26 adityachoudhari26 deleted the aman/otel-stackdriver-support branch June 18, 2024 17:47
jsbroks pushed a commit that referenced this pull request Jun 18, 2024
## [3.3.0](v3.2.0...v3.3.0) (2024-06-18)

### Features

* Added service account name in stackdriver conf ([#136](#136)) ([87aa2b9](87aa2b9)), closes [#113](#113)
@jsbroks
Copy link
Member

jsbroks commented Jun 18, 2024

This PR is included in version 3.3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants