feat: Changes to Connect to AWS S3 and KMS using IAM role for EKS service account #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gls4
suggested changes
Mar 5, 2024
There was a problem hiding this comment.
All of the IAM policies related to EKS are located in the iam*.tf files in the root of the app_eks module. I do not want a submodule created for these, as it adds additional complexity without clear benefit. Please integrate the changes following the pattern used for the existing IAM policies applied to the EKS cluster, without the use of additional third-party modules.
gls4
approved these changes
Mar 7, 2024
jsbroks
reviewed
May 10, 2024
jsbroks
reviewed
May 10, 2024
jsbroks
reviewed
May 10, 2024
jsbroks
reviewed
May 10, 2024
jsbroks
requested changes
May 10, 2024
There was a problem hiding this comment.
https://www.terraform-best-practices.com/naming#resource-and-data-source-arguments
Do not repeat resource type in resource name (not partially, nor completely)
jsbroks
approved these changes
May 17, 2024
jsbroks
pushed a commit
that referenced
this pull request
May 18, 2024
## [4.11.0](v4.10.2...v4.11.0) (2024-05-18) ### Features * Changes to Connect to AWS S3 and KMS using IAM role for EKS service account ([#186](#186)) ([a07a45e](a07a45e))
|
This PR is included in version 4.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179
Connect to AWS S3 and KMS using IAM role for EKS service account