feat: Add standardized instance sizing in AWS #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfoucha
approved these changes
Jan 30, 2024
|
should probably run this through the tf formatter |
added 2 commits
February 7, 2024 10:13
|
This PR is included in version 4.3.0 🎉 |
zacharyblasczyk
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Veronica/tshirt deployment (#171) * feat: Add support for t-shirt-sized deployments * Remove duplicates --------- Co-authored-by: Veronica JungYeon Kim <veronica@wandb.com> * changes * test * terraform fmt * touchups * a bit o polish --------- Co-authored-by: Veronica JungYeon Kim <veronica@wandb.com>
yogeshg
reviewed
Feb 21, 2024
| @@ -26,12 +26,27 @@ output "database_password" { | |||
| sensitive = true | |||
| value = module.database.password | |||
| } | |||
|
|
|||
| output "database_instance_type" { | |||
| value = local.deployment_size[var.size].db | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues work done by @kimjyhello to enable standardization of resource sizes across EKS node, RDS instance, and Elasticache node types.